Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(57)

Issue 705041: Support schemaless URLs in gadgets.io.getProxyUrl (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
16 years ago by johnfargo
Modified:
16 years ago
Reviewers:
Paul Lindner, zhoresh, shindig.remailer
Base URL:
http://svn.apache.org/repos/asf/shindig/trunk/
Visibility:
Public.

Description

Schemaless URLs seem to work fine except in the SWF + AS3 ExternalInterface case, where despite actually resolving to the same protocol+host, authority-mismatch errors occur. Given JS has access to the current protocol anyway, we can simply use it to avoid this case. This is similar to the way makeRequest works.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -1 line) Patch
features/src/main/javascript/features/core.io/io.js View 1 chunk +5 lines, -1 line 0 comments Download
features/src/test/javascript/features/core.io/iotest.js View 2 chunks +19 lines, -0 lines 0 comments Download

Messages

Total messages: 3
johnfargo
16 years ago (2010-03-23 22:35:52 UTC) #1
zhoresh
LGTM
16 years ago (2010-03-23 23:20:41 UTC) #2
Paul Lindner
16 years ago (2010-03-23 23:27:01 UTC) #3
ditto, lgtm.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b