Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3059)

Issue 7041044: Cast int to SkScalar in SkCanvas (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 10 months ago by rmistry
Modified:
11 years, 10 months ago
Reviewers:
epoger, reed1
CC:
skia-review_googlegroups.com, skiabot_google.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

The motivation for this changeset is to fix the following build failure in google3- third_party/skia/src/core/SkCanvas.cpp:1711:61: error: non-constant-expression cannot be narrowed from type 'int32_t' (aka 'int') to 'SkScalar' (aka 'float') in initializer list [-Wc++11-narrowing] 0, SkIntToScalar(c.fLeft), SkIntToScalar(c.fRight), w ^ third_party/skia/src/core/SkCanvas.cpp:1711:61: note: override this message by inserting an explicit cast 0, SkIntToScalar(c.fLeft), SkIntToScalar(c.fRight), w ^ static_cast<SkScalar>( ) Committed: https://code.google.com/p/skia/source/detail?r=6979

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/core/SkCanvas.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3
rmistry
11 years, 10 months ago (2013-01-02 21:59:24 UTC) #1
reed1
lgtm
11 years, 10 months ago (2013-01-02 22:01:51 UTC) #2
epoger
11 years, 10 months ago (2013-01-03 18:32:36 UTC) #3
Message was sent while issue was closed.
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b