Don't accept 403 by default for auth challenge.

Fixes issue #230.

[Ali Afshar, 2013-01-03 20:44:04]

https://codereview.appspot.com/7039053/diff/1/oauth2client/client.py
File oauth2client/client.py (right):

https://codereview.appspot.com/7039053/diff/1/oauth2client/client.py#newcode61
oauth2client/client.py:61: REFRESH_STATUS_CODES = [401]
set()

[jcgregorio_google, 2013-01-03 20:59:44]

set() is not necessarily faster for small sizes sets.

>>> timeit.timeit('401 in CODES', setup='CODES = set([401])', number=10000000)
0.39968013763427734
>>> timeit.timeit('401 in CODES', setup='CODES = set([401, 403])',
number=10000000)
0.40685200691223145
>>> timeit.timeit('401 in CODES', setup='CODES = [401]', number=10000000)
0.3131840229034424
>>> timeit.timeit('401 in CODES', setup='CODES = [401, 403]', number=10000000)
0.3129160404205322
>>>

On Thu, Jan 3, 2013 at 3:44 PM,  <afshar@google.com> wrote:
>
> https://codereview.appspot.com/7039053/diff/1/oauth2client/client.py
> File oauth2client/client.py (right):
>
>
https://codereview.appspot.com/7039053/diff/1/oauth2client/client.py#newcode61
> oauth2client/client.py:61: REFRESH_STATUS_CODES = [401]
> set()
>
> https://codereview.appspot.com/7039053/

[Ali Afshar, 2013-01-03 21:45:36]

On 2013/01/03 20:59:44, jcgregorio_google wrote:
> set() is not necessarily faster for small sizes sets.
> 
> >>> timeit.timeit('401 in CODES', setup='CODES = set([401])', number=10000000)
> 0.39968013763427734
> >>> timeit.timeit('401 in CODES', setup='CODES = set([401, 403])',
> number=10000000)
> 0.40685200691223145
> >>> timeit.timeit('401 in CODES', setup='CODES = [401]', number=10000000)
> 0.3131840229034424
> >>> timeit.timeit('401 in CODES', setup='CODES = [401, 403]', number=10000000)
> 0.3129160404205322
> >>>
> 
> On Thu, Jan 3, 2013 at 3:44 PM,  <mailto:afshar@google.com> wrote:
> >
> > https://codereview.appspot.com/7039053/diff/1/oauth2client/client.py
> > File oauth2client/client.py (right):
> >
> >
> https://codereview.appspot.com/7039053/diff/1/oauth2client/client.py#newcode61
> > oauth2client/client.py:61: REFRESH_STATUS_CODES = [401]
> > set()
> >
> > https://codereview.appspot.com/7039053/

Interesting, thanks. LGTM

[jcgregorio_google, 2013-01-03 22:19:16]

Committed at
http://code.google.com/p/google-api-python-client/source/detail?r=accbae09fb5...

On 2013/01/03 21:45:36, Ali Afshar wrote:
> On 2013/01/03 20:59:44, jcgregorio_google wrote:
> > set() is not necessarily faster for small sizes sets.
> > 
> > >>> timeit.timeit('401 in CODES', setup='CODES = set([401])',
number=10000000)
> > 0.39968013763427734
> > >>> timeit.timeit('401 in CODES', setup='CODES = set([401, 403])',
> > number=10000000)
> > 0.40685200691223145
> > >>> timeit.timeit('401 in CODES', setup='CODES = [401]', number=10000000)
> > 0.3131840229034424
> > >>> timeit.timeit('401 in CODES', setup='CODES = [401, 403]',
number=10000000)
> > 0.3129160404205322
> > >>>
> > 
> > On Thu, Jan 3, 2013 at 3:44 PM,  <mailto:afshar@google.com> wrote:
> > >
> > > https://codereview.appspot.com/7039053/diff/1/oauth2client/client.py
> > > File oauth2client/client.py (right):
> > >
> > >
> >
https://codereview.appspot.com/7039053/diff/1/oauth2client/client.py#newcode61
> > > oauth2client/client.py:61: REFRESH_STATUS_CODES = [401]
> > > set()
> > >
> > > https://codereview.appspot.com/7039053/
> 
> Interesting, thanks. LGTM