Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1974)

Issue 7039047: Updated cpplint.py to #224: (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 10 months ago by erg
Modified:
11 years, 10 months ago
Reviewers:
Mark Mentovai
CC:
Mark Mentovai, erg
Base URL:
http://google-styleguide.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Updated cpplint.py to #224: - Better emacs-flymake integration - Fix false positives in macros and template parameters - Improve the wording on the make_pair warning - Remove virtual keyword checks (now a warning in clang) - Add checks for namespaces - Check that DISALLOW_* macros are always in the "private:" section - Fix false positives for gMock - Check for alternative boolean operator tokens - Fix false positives for space on parens - Fix false positives about placement of "{" near preprocessor macros - Don't lint inside inlined assembler - Don't warn on "auto"; it is now a type shortcut, not a storage class - Don't warn on c++11 for loops - Warn on empty loop bodies - Don't warn on unnamed args for the postincrement operator - Fixes for "<" placement now allowed in c++11 Committed: https://code.google.com/p/google-styleguide/source/detail?r=99

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1545 lines, -356 lines) Patch
M cpplint/cpplint.py View 45 chunks +803 lines, -171 lines 0 comments Download
M cpplint/cpplint_unittest.py View 25 chunks +742 lines, -185 lines 0 comments Download

Messages

Total messages: 2
erg
This is like a year late and there's 20 more patches to either port over ...
11 years, 10 months ago (2013-01-02 20:44:51 UTC) #1
Mark Mentovai
11 years, 10 months ago (2013-01-14 16:41:50 UTC) #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b