Issue 7038048: Extend skdiff to report alpha channel differences

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7038048: Extend skdiff to report alpha channel differences (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 9 months ago by rmistry

Modified:
11 years, 9 months ago

Reviewers:
epoger

CC:
skia-review_googlegroups.com, skiabot_google.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

* Extended skdiff to report alpha channel differences. * Created a tools/tests/rebaseline.sh to copy output-actual into output-expected. * Sample results are available here: http://www.corp.google.com/~rmistry/skia/gm-playback-windows/images-skdiff/ Committed: https://code.google.com/p/skia/source/detail?r=7003

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Patch Set 8 : #

Patch Set 9 : Extend skdiff to report alpha channel differences #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+106 lines, -6 lines)			Patch
M	tools/skdiff.h	View	1 2 3 4 5 6 7 8	2 chunks	+7 lines, -0 lines	0 comments	Download
M	tools/skdiff.cpp	View	1 2 3 4 5 6 7 8	3 chunks	+11 lines, -4 lines	0 comments	Download
M	tools/skdiff_html.cpp	View	1 2 3 4 5 6 7 8	1 chunk	+13 lines, -0 lines	0 comments	Download
A	tools/tests/rebaseline.sh	View	1 2 3 4	1 chunk	+73 lines, -0 lines	0 comments	Download
M	tools/tests/skdiff/test1/output-expected/index.html	View	1 2 3 4 5 6 7 8	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Extend skdiff to report alpha channel differences

Expand All Messages | Collapse All Messages