Script to checkout and build ToT chromium with ToT skia

Script to checkout and build ToT chromium with ToT skia
Committed: https://code.google.com/p/skia/source/detail?r=7079

[epoger, 2013-01-04 16:23:27]

LGTM with minor suggestions

Seems like this will be generally helpful, so thanks for sharing.  You may want
to...

1. coordinate with Mike (to see how this differs from how he typically does such
a thing)

2. document the existence of this script somewhere under
https://sites.google.com/site/skiadocs/developer-documentation/managing-chrom...

https://codereview.appspot.com/7036049/diff/1/tools/build-tot-chromium.sh
File tools/build-tot-chromium.sh (right):

https://codereview.appspot.com/7036049/diff/1/tools/build-tot-chromium.sh#new...
tools/build-tot-chromium.sh:5: # Script to checkout and build a fresh copy of
chromium from head that uses top
or perhaps, more explicitly:

Script to checkout and build a fresh copy of Chromium from head that uses a
writable, tip-of-tree Skia rather than the read-only, revision-locked Skia
specified in http://src.chromium.org/viewvc/chrome/trunk/src/DEPS .

https://codereview.appspot.com/7036049/diff/1/tools/build-tot-chromium.sh#new...
tools/build-tot-chromium.sh:46: export GYP_GENERATORS=’ninja’
Alternatively, combine lines 46&47 to explicitly set GYP_GENERATORS for ONLY
gyp_chromium:

GYP_GENERATORS='ninja' ./build/gyp_chromium

https://codereview.appspot.com/7036049/diff/1/tools/build-tot-chromium.sh#new...
tools/build-tot-chromium.sh:56: echo -e "\n\n========The Chromium & Skia
versions are $(SVN_VERSION)========\n\n"
Doesn't svnversion just report a single number, which would be the Chromium
revision when cd'd into ../src ?

[rmistry, 2013-01-07 12:56:25]

https://codereview.appspot.com/7036049/diff/1/tools/build-tot-chromium.sh
File tools/build-tot-chromium.sh (right):

https://codereview.appspot.com/7036049/diff/1/tools/build-tot-chromium.sh#new...
tools/build-tot-chromium.sh:5: # Script to checkout and build a fresh copy of
chromium from head that uses top
On 2013/01/04 16:23:27, epoger wrote:
> or perhaps, more explicitly:
> 
> Script to checkout and build a fresh copy of Chromium from head that uses a
> writable, tip-of-tree Skia rather than the read-only, revision-locked Skia
> specified in http://src.chromium.org/viewvc/chrome/trunk/src/DEPS .

Done.

https://codereview.appspot.com/7036049/diff/1/tools/build-tot-chromium.sh#new...
tools/build-tot-chromium.sh:46: export GYP_GENERATORS=’ninja’
On 2013/01/04 16:23:27, epoger wrote:
> Alternatively, combine lines 46&47 to explicitly set GYP_GENERATORS for ONLY
> gyp_chromium:
> 
> GYP_GENERATORS='ninja' ./build/gyp_chromium

Done.

https://codereview.appspot.com/7036049/diff/1/tools/build-tot-chromium.sh#new...
tools/build-tot-chromium.sh:56: echo -e "\n\n========The Chromium & Skia
versions are $(SVN_VERSION)========\n\n"
On 2013/01/04 16:23:27, epoger wrote:
> Doesn't svnversion just report a single number, which would be the Chromium
> revision when cd'd into ../src ?

When you add the section on line 22 to your .gclient 'svnversion .' prints the
following format:
7013:175144S

which is the skia_version and chromium_version

[rmistry, 2013-01-07 13:02:21]

Hi Mike,

This is the script I have been using to build a fresh copy of Chromium from head
(I setup a cronjob that runs this script nightly on my desktop).
Does this look like it could be useful to have in tools? is your process for
setting up a chromium build any different than what is in the script?

Thanks!