Issue 7030065: Remove SkRefPtr

Issue 7030065: Remove SkRefPtr (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years ago by Steve VanDeBogart

Modified:
11 years, 12 months ago

Reviewers:
junov, robertphillips, reed1

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Remove SkRefPtr (resubmit of https://codereview.appspot.com/7030059/) TBR=junov@google.com Committed: https://code.google.com/p/skia/source/detail?r=7030

Patch Set 2 : samplecode too #

Total comments: 2

Created: 12 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+180 lines, -328 lines)			Patch
M	include/core/SkRefCnt.h	View		1 chunk	+0 lines, -32 lines	0 comments	Download
M	samplecode/SampleTextureDomain.cpp	View	1	1 chunk	+3 lines, -3 lines	2 comments	Download
M	src/pdf/SkPDFDevice.cpp	View		13 chunks	+24 lines, -34 lines	0 comments	Download
M	src/pdf/SkPDFDocument.cpp	View		1 chunk	+2 lines, -4 lines	0 comments	Download
M	src/pdf/SkPDFFont.h	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	src/pdf/SkPDFFont.cpp	View		25 chunks	+62 lines, -89 lines	0 comments	Download
M	src/pdf/SkPDFFormXObject.cpp	View		2 chunks	+2 lines, -4 lines	0 comments	Download
M	src/pdf/SkPDFGraphicState.cpp	View		3 chunks	+6 lines, -10 lines	0 comments	Download
M	src/pdf/SkPDFImage.cpp	View		2 chunks	+7 lines, -12 lines	0 comments	Download
M	src/pdf/SkPDFPage.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/pdf/SkPDFPage.cpp	View		4 chunks	+8 lines, -14 lines	0 comments	Download
M	src/pdf/SkPDFShader.cpp	View		4 chunks	+9 lines, -14 lines	0 comments	Download
M	src/pdf/SkPDFStream.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/pdf/SkPDFStream.cpp	View		4 chunks	+8 lines, -8 lines	0 comments	Download
M	src/pdf/SkPDFTypes.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/pdf/SkPDFTypes.cpp	View		1 chunk	+4 lines, -1 line	0 comments	Download
M	tests/PDFPrimitivesTest.cpp	View		6 chunks	+37 lines, -65 lines	0 comments	Download
M	tests/UtilsTest.cpp	View		2 chunks	+0 lines, -30 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

Steve VanDeBogart

Only thing new in this CL is the diff between patch set 1 and patch ...

12 years ago (2013-01-04 19:31:00 UTC) #1

reed1

https://codereview.appspot.com/7030065/diff/2001/samplecode/SampleTextureDomain.cpp File samplecode/SampleTextureDomain.cpp (right): https://codereview.appspot.com/7030065/diff/2001/samplecode/SampleTextureDomain.cpp#newcode63 samplecode/SampleTextureDomain.cpp:63: // when copying from one GPU device to another. ...

12 years ago (2013-01-04 19:35:53 UTC) #2

Steve VanDeBogart

Fixed in r7032 https://codereview.appspot.com/7030065/diff/2001/samplecode/SampleTextureDomain.cpp File samplecode/SampleTextureDomain.cpp (right): https://codereview.appspot.com/7030065/diff/2001/samplecode/SampleTextureDomain.cpp#newcode63 samplecode/SampleTextureDomain.cpp:63: // when copying from one GPU ...

12 years ago (2013-01-04 19:43:58 UTC) #3

robertphillips

I re-added the definition of SkRefPtr in SkRefCnt.h in r7044 (http://code.google.com/p/skia/source/detail?r=7044) until all uses in ...

11 years, 12 months ago (2013-01-07 13:36:22 UTC) #5

Steve VanDeBogart

11 years, 12 months ago (2013-01-07 21:47:25 UTC) #6

Message was sent while issue was closed.

On 2013/01/07 13:36:22, robertphillips wrote:
> I re-added the definition of SkRefPtr in SkRefCnt.h in r7044
> (http://code.google.com/p/skia/source/detail?r=7044) until all uses in Chrome
> have been cleaned up.

Sorry, I searched chrome/src/skia/ext for consumers and didn't see any. Ooops.

Expand All Messages | Collapse All Messages