Issue 7030059: Remove SkRefPtr

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7030059: Remove SkRefPtr (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 6 months ago by Steve VanDeBogart

Modified:
11 years, 5 months ago

Reviewers:
bungeman, reed1

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

Remove SkRefPtr Committed: https://code.google.com/p/skia/source/detail?r=7021

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+177 lines, -325 lines)			Patch
M	include/core/SkRefCnt.h	View	1 chunk	+0 lines, -32 lines	0 comments	Download
M	src/pdf/SkPDFDevice.cpp	View	13 chunks	+24 lines, -34 lines	0 comments	Download
M	src/pdf/SkPDFDocument.cpp	View	1 chunk	+2 lines, -4 lines	0 comments	Download
M	src/pdf/SkPDFFont.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	src/pdf/SkPDFFont.cpp	View	25 chunks	+62 lines, -89 lines	0 comments	Download
M	src/pdf/SkPDFFormXObject.cpp	View	2 chunks	+2 lines, -4 lines	0 comments	Download
M	src/pdf/SkPDFGraphicState.cpp	View	3 chunks	+6 lines, -10 lines	0 comments	Download
M	src/pdf/SkPDFImage.cpp	View	2 chunks	+7 lines, -12 lines	0 comments	Download
M	src/pdf/SkPDFPage.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/pdf/SkPDFPage.cpp	View	4 chunks	+8 lines, -14 lines	0 comments	Download
M	src/pdf/SkPDFShader.cpp	View	4 chunks	+9 lines, -14 lines	0 comments	Download
M	src/pdf/SkPDFStream.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/pdf/SkPDFStream.cpp	View	4 chunks	+8 lines, -8 lines	0 comments	Download
M	src/pdf/SkPDFTypes.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pdf/SkPDFTypes.cpp	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	tests/PDFPrimitivesTest.cpp	View	6 chunks	+37 lines, -65 lines	0 comments	Download
M	tests/UtilsTest.cpp	View	2 chunks	+0 lines, -30 lines	0 comments	Download

Total messages: 2

Steve VanDeBogart

I'm tired of people complaining about SkRefPtr... ;-)

11 years, 6 months ago (2013-01-04 01:52:58 UTC) #1

lgtm