Issue 7030054: Add PEM support.

Issue 7030054: Add PEM support. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 6 months ago by jcgregorio_google

Modified:
12 years, 6 months ago

Reviewers:
jcgregorio_google, Ali Afshar

CC:
google-api-python-client_googlegroups.com

Visibility:
Public.

Patch Set 2 : Expand unit tests. #

Patch Set 4 : remove HAS_ checks #

Created: 12 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+281 lines, -100 lines)			Patch
M	oauth2client/client.py	View	1 2	7 chunks	+16 lines, -18 lines	0 comments	Download
M	oauth2client/crypt.py	View	1 2 3	1 chunk	+202 lines, -71 lines	0 comments	Download
M	tests/test_oauth2client_jwt.py	View	1 2	9 chunks	+62 lines, -11 lines	0 comments	Download
M	tox.ini	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 7

Expand All Messages | Collapse All Messages

Ali Afshar

https://codereview.appspot.com/7030054/diff/4001/oauth2client/crypt.py File oauth2client/crypt.py (right): https://codereview.appspot.com/7030054/diff/4001/oauth2client/crypt.py#newcode54 oauth2client/crypt.py:54: if HAS_OPENSSL: I'm uncomfortable with this style of hiding ...

12 years, 6 months ago (2013-01-03 16:07:53 UTC) #2

jcgregorio_google

12 years, 6 months ago (2013-01-03 18:13:44 UTC) #3

Ali Afshar

On 2013/01/03 18:13:44, jcgregorio_google wrote: > https://codereview.appspot.com/7030054/diff/4001/oauth2client/crypt.py > File oauth2client/crypt.py (right): > > https://codereview.appspot.com/7030054/diff/4001/oauth2client/crypt.py#newcode54 > ...

12 years, 6 months ago (2013-01-03 19:47:37 UTC) #4

jcgregorio_google

It's there: https://codereview.appspot.com/7030054/diff2/4001:8001/oauth2client/crypt.py On Thu, Jan 3, 2013 at 2:47 PM, <afshar@google.com> wrote: > On ...

12 years, 6 months ago (2013-01-03 19:48:57 UTC) #5

Ali Afshar

Thanks, LGTM On 2013/01/03 19:48:57, jcgregorio_google wrote: > It's there: > > https://codereview.appspot.com/7030054/diff2/4001:8001/oauth2client/crypt.py > > ...

12 years, 6 months ago (2013-01-03 19:49:35 UTC) #6

jcgregorio_google

12 years, 6 months ago (2013-01-03 20:03:54 UTC) #7

Committed in
http://code.google.com/p/google-api-python-client/source/detail?r=5c952c4cea9...

On Thu, Jan 3, 2013 at 2:49 PM,  <afshar@google.com> wrote:
> Thanks, LGTM
>
>
> On 2013/01/03 19:48:57, jcgregorio_google wrote:
>>
>> It's there:
>
>
>
> https://codereview.appspot.com/7030054/diff2/4001:8001/oauth2client/crypt.py
>
>> On Thu, Jan 3, 2013 at 2:47 PM,  <mailto:afshar@google.com> wrote:
>> > On 2013/01/03 18:13:44, jcgregorio_google wrote:
>> >>
>> >>
>
> https://codereview.appspot.com/7030054/diff/4001/oauth2client/crypt.py
>>
>> >> File oauth2client/crypt.py (right):
>> >
>> >
>> >
>> >
>
>
>
https://codereview.appspot.com/7030054/diff/4001/oauth2client/crypt.py#newcode54
>>
>> >>
>> >> oauth2client/crypt.py:54: if HAS_OPENSSL:
>> >> Done. Much cleaner.
>> >
>> >
>> >> On 2013/01/03 16:07:53, Ali Afshar wrote:
>> >> > I'm uncomfortable with this style of hiding a class definition
>> >
>> > behind an if
>> >>
>> >> > statement. I would prefer setting the class to None if openssl is
>> >
>> > not
>> >>
>> >> available.
>> >
>> >
>> >
>> >
>
>
>
https://codereview.appspot.com/7030054/diff/4001/oauth2client/crypt.py#newcod...
>>
>> >>
>> >> oauth2client/crypt.py:148: if HAS_PYCRYPTO:
>> >> On 2013/01/03 16:07:53, Ali Afshar wrote:
>> >> > As above.
>> >
>> >
>> >> Done.
>> >
>> >
>> > I can't see this done, are we missing a version?
>> >
>> > https://codereview.appspot.com/7030054/
>
>
>
>
> https://codereview.appspot.com/7030054/

Expand All Messages | Collapse All Messages