Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(934)

Issue 7027051: Disable GL_OES_standard_derivatives when ps_2_x or later is not available. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 7 months ago by bsalomon
Modified:
11 years, 7 months ago
Reviewers:
dgkoch, nicolas
CC:
angleproject-review_googlegroups.com
Base URL:
http://angleproject.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Disable GL_OES_standard_derivatives when ps_2_x or later is not available. BUG=392 Committed: https://code.google.com/p/angleproject/source/detail?r=1641

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -3 lines) Patch
M src/libGLESv2/Context.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/libGLESv2/Context.cpp View 1 2 3 3 chunks +10 lines, -2 lines 0 comments Download
M src/libGLESv2/Shader.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7
bsalomon
11 years, 7 months ago (2013-01-03 21:53:24 UTC) #1
nicolas
The correct check for support for this is to test for the D3DPS20CAPS_GRADIENTINSTRUCTIONS flag in ...
11 years, 7 months ago (2013-01-03 22:02:15 UTC) #2
bsalomon
On 2013/01/03 22:02:15, nicolas wrote: > The correct check for support for this is to ...
11 years, 7 months ago (2013-01-03 22:06:26 UTC) #3
bsalomon
New patch uses D3DPS20CAPS_GRADIENTINSTRUCTIONS
11 years, 7 months ago (2013-01-03 22:10:33 UTC) #4
nicolas
On 2013/01/03 22:10:33, bsalomon wrote: > New patch uses D3DPS20CAPS_GRADIENTINSTRUCTIONS Thanks. Looks ok to me. ...
11 years, 7 months ago (2013-01-03 22:25:26 UTC) #5
bsalomon
On 2013/01/03 22:25:26, nicolas wrote: > On 2013/01/03 22:10:33, bsalomon wrote: > > New patch ...
11 years, 7 months ago (2013-01-04 13:42:39 UTC) #6
dgkoch
11 years, 7 months ago (2013-01-04 15:12:15 UTC) #7
LGTM.  Nice find btw!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b