Issue 70250045: code review 70250045: runtime: update NetBSD/ARM port to EABI.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 70250045: code review 70250045: runtime: update NetBSD/ARM port to EABI.

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 10 months ago by minux1

Modified:
11 years, 8 months ago

Reviewers:
rsc, jsing, golang-codereviews

Visibility:
Public.

Description

runtime: update NetBSD/ARM port to EABI.

Patch Set 2 : diff -r 63f448126b28 https://code.google.com/p/go #

Patch Set 3 : diff -r 63f448126b28 https://code.google.com/p/go #

Total comments: 1

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -1 line)			Patch
	M	src/pkg/runtime/defs_netbsd_arm.h	View	1	4 chunks	+11 lines, -1 line	1 comment	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

minux1

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

11 years, 10 months ago (2014-03-03 08:09:41 UTC) #1

jsing

https://codereview.appspot.com/70250045/diff/40001/src/pkg/runtime/defs_netbsd_arm.h File src/pkg/runtime/defs_netbsd_arm.h (right): https://codereview.appspot.com/70250045/diff/40001/src/pkg/runtime/defs_netbsd_arm.h#newcode4 src/pkg/runtime/defs_netbsd_arm.h:4: #define __ARM_EABI__ Is this generated, or hand edited?

11 years, 10 months ago (2014-03-03 11:48:34 UTC) #2

minux1

On Mar 3, 2014 6:48 AM, <jsing@google.com> wrote: > > > https://codereview.appspot.com/70250045/diff/40001/src/pkg/runtime/defs_netbsd_arm.h > File src/pkg/runtime/defs_netbsd_arm.h ...

11 years, 10 months ago (2014-03-03 18:09:14 UTC) #3

jsing

On 2014/03/03 18:09:14, minux wrote: > On Mar 3, 2014 6:48 AM, <mailto:jsing@google.com> wrote: > ...

11 years, 10 months ago (2014-03-05 15:38:10 UTC) #4

R=close

'hg mail' to reopen once 1.3 is out.

Expand All Messages | Collapse All Messages