Issue 6999052: Incorporated BSD-licensed changes implementing array bounds clamping.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6999052: Incorporated BSD-licensed changes implementing array bounds clamping. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 10 months ago by kbr1

Modified:
11 years, 10 months ago

Reviewers:
vangelis, VangelisK

CC:
angleproject-review_googlegroups.com

Base URL:
http://angleproject.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Incorporated BSD-licensed changes implementing array bounds clamping. BUG=none TEST=ran associated WebKit layout tests in Chromium Committed: https://code.google.com/p/angleproject/source/detail?r=1638

Patch Set 1 #

Patch Set 2 : #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+218 lines, -6 lines)			Patch
M	AUTHORS	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	include/GLSLANG/ShaderLang.h	View		1 chunk	+7 lines, -1 line	0 comments	Download
M	src/build_angle.gypi	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/common/version.h	View		1 chunk	+1 line, -1 line	0 comments	Download
A	src/compiler/ArrayBoundsClamper.h	View		1 chunk	+57 lines, -0 lines	0 comments	Download
A	src/compiler/ArrayBoundsClamper.cpp	View		1 chunk	+88 lines, -0 lines	0 comments	Download
M	src/compiler/Compiler.cpp	View		4 chunks	+12 lines, -0 lines	0 comments	Download
M	src/compiler/OutputGLSLBase.cpp	View		1 chunk	+30 lines, -1 line	0 comments	Download
M	src/compiler/ShHandle.h	View		3 chunks	+3 lines, -0 lines	0 comments	Download
M	src/compiler/TranslatorESSL.cpp	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/compiler/TranslatorGLSL.cpp	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/compiler/intermOut.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/compiler/intermediate.h	View		2 chunks	+7 lines, -1 line	0 comments	Download
M	src/compiler/translator_common.vcxproj	View		3 chunks	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Looks reasonable..

LGTM

Expand All Messages | Collapse All Messages