Issue 6998048: Add appengineutil package with OAuth helpers for App Engine

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6998048: Add appengineutil package with OAuth helpers for App Engine

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years ago by jasonhall

Modified:
13 years ago

Reviewers:
adg

Visibility:
Public.

More Reviews

Description

Add appengineutil package with OAuth helpers for App Engine

Patch Set 2 : . #

Total comments: 12

Created: 13 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+247 lines, -0 lines)			Patch
A	oauth/appengineutil/appengineutil.go	View		1 chunk	+189 lines, -0 lines	12 comments	Download
A	oauth/appengineutil/example/app.yaml	View	1	1 chunk	+8 lines, -0 lines	0 comments	Download
A	oauth/appengineutil/example/app/app.go	View		1 chunk	+50 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

adg

https://codereview.appspot.com/6998048/diff/5/oauth/appengineutil/appengineutil.go File oauth/appengineutil/appengineutil.go (right): https://codereview.appspot.com/6998048/diff/5/oauth/appengineutil/appengineutil.go#newcode147 oauth/appengineutil/appengineutil.go:147: type datastoreCache struct { You should export this so ...

13 years ago (2013-01-08 00:50:56 UTC) #1

adg

13 years ago (2013-01-08 00:53:52 UTC) #2

https://codereview.appspot.com/6998048/diff/5/oauth/appengineutil/appengineut...
File oauth/appengineutil/appengineutil.go (right):

https://codereview.appspot.com/6998048/diff/5/oauth/appengineutil/appengineut...
oauth/appengineutil/appengineutil.go:83: config.RedirectURL = getRedirectURL(c)
I think you should export getRedirectURL too, and don't mutate config inside
MustOAuth and NewOAuthCallbackHandlerFunc

https://codereview.appspot.com/6998048/diff/5/oauth/appengineutil/appengineut...
oauth/appengineutil/appengineutil.go:118: // Make a local copy of the config.
I don't think this is necessary. We can probably rely on the OAuth config being
static.

Expand All Messages | Collapse All Messages