Issue 6970044: Tweak Android bench_pictures configs

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6970044: Tweak Android bench_pictures configs (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 11 months ago by EricB

Modified:
12 years, 11 months ago

Reviewers:
DerekS

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Tweak Android bench_pictures configs Committed: https://code.google.com/p/skia/source/detail?r=6895

Patch Set 3 : #

Created: 12 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -24 lines)			Patch
	M	tools/bench_pictures.cfg	View	1 2	4 chunks	+11 lines, -12 lines	0 comments	Download
	M	tools/bench_pictures_cfg_helper.py	View	1 2	3 chunks	+9 lines, -12 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

DerekS

lgtm after this one change https://codereview.appspot.com/6970044/diff/1/tools/bench_pictures_cfg_helper.py File tools/bench_pictures_cfg_helper.py (right): https://codereview.appspot.com/6970044/diff/1/tools/bench_pictures_cfg_helper.py#newcode67 tools/bench_pictures_cfg_helper.py:67: def RTreeConfig(tile_x, tile_y, mode, ...

12 years, 11 months ago (2012-12-19 13:56:43 UTC) #2

EricB

https://codereview.appspot.com/6970044/diff/1/tools/bench_pictures_cfg_helper.py File tools/bench_pictures_cfg_helper.py (right): https://codereview.appspot.com/6970044/diff/1/tools/bench_pictures_cfg_helper.py#newcode67 tools/bench_pictures_cfg_helper.py:67: def RTreeConfig(tile_x, tile_y, mode, **kwargs): On 2012/12/19 13:56:43, DerekS ...

12 years, 11 months ago (2012-12-19 14:34:10 UTC) #3

lgtm

Expand All Messages | Collapse All Messages