Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(58)

Issue 6963043: Google Drive Parser (my first parser!) (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 11 months ago by david.nides
Modified:
11 years, 10 months ago
Reviewers:
kiddi
CC:
log2timeline-dev_googlegroups.com
Visibility:
Public.

Description

Google Drive Parser (my first parser!)

Patch Set 1 #

Total comments: 42

Patch Set 2 : . #

Total comments: 1

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : . #

Total comments: 4

Patch Set 6 : . #

Patch Set 7 : . #

Patch Set 8 : . #

Patch Set 9 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+165 lines, -25 lines) Patch
M parsers/__init__.py View 1 2 3 4 5 1 chunk +2 lines, -1 line 0 comments Download
A parsers/gdrive.py View 1 2 3 4 5 1 chunk +59 lines, -24 lines 0 comments Download
A parsers/gdrive.py View 1 2 3 6 7 8 1 chunk +104 lines, -0 lines 0 comments Download

Messages

Total messages: 17
david.nides
11 years, 11 months ago (2012-12-19 00:09:53 UTC) #1
kiddi
few comments https://codereview.appspot.com/6963043/diff/1/parsers/__init__.py File parsers/__init__.py (right): https://codereview.appspot.com/6963043/diff/1/parsers/__init__.py#newcode26 parsers/__init__.py:26: from plaso.parsers import winreg don't copy paste ...
11 years, 11 months ago (2012-12-20 17:01:42 UTC) #2
david.nides
See comments https://codereview.appspot.com/6963043/diff/1/parsers/__init__.py File parsers/__init__.py (right): https://codereview.appspot.com/6963043/diff/1/parsers/__init__.py#newcode26 parsers/__init__.py:26: from plaso.parsers import winreg On 2012/12/20 17:01:42, ...
11 years, 11 months ago (2012-12-20 21:46:10 UTC) #3
david.nides
.
11 years, 11 months ago (2012-12-20 22:08:47 UTC) #4
kiddi
there seems to be an issue with the upload .... the gdrive seems to have ...
11 years, 11 months ago (2012-12-20 22:10:04 UTC) #5
david.nides
.
11 years, 11 months ago (2012-12-21 04:30:22 UTC) #6
david.nides
.
11 years, 11 months ago (2012-12-21 04:45:56 UTC) #7
david.nides
.
11 years, 11 months ago (2012-12-21 05:00:33 UTC) #8
kiddi
few more comments.... sending code samples in mail https://codereview.appspot.com/6963043/diff/1/parsers/gdrive.py File parsers/gdrive.py (right): https://codereview.appspot.com/6963043/diff/1/parsers/gdrive.py#newcode47 parsers/gdrive.py:47: '2': ...
11 years, 11 months ago (2012-12-21 18:12:05 UTC) #9
david.nides
Thank you. Odd, when I click on the urls to reply to the comments I ...
11 years, 11 months ago (2012-12-21 19:06:55 UTC) #10
david.nides
.
11 years, 11 months ago (2012-12-21 20:10:39 UTC) #11
kiddi
You need to upload again. This weird "error in upload" is happening again, preventing me ...
11 years, 11 months ago (2012-12-23 15:47:48 UTC) #12
david.nides
.
11 years, 11 months ago (2012-12-23 22:35:17 UTC) #13
david.nides
https://codereview.appspot.com/6963043/diff/13004/parsers/gdrive.py File parsers/gdrive.py (right): https://codereview.appspot.com/6963043/diff/13004/parsers/gdrive.py#newcode61 parsers/gdrive.py:61: row['filename'], On 2012/12/21 18:12:05, kiddi wrote: > wrong indentation, ...
11 years, 11 months ago (2012-12-23 22:49:50 UTC) #14
david.nides
.
11 years, 11 months ago (2012-12-23 22:51:34 UTC) #15
david.nides
.
11 years, 11 months ago (2012-12-23 22:58:16 UTC) #16
kiddi
11 years, 11 months ago (2012-12-24 15:49:35 UTC) #17
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b