Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(218)

Issue 6962048: unify how we handle externally-provided storage in SkWriter32, with the goal (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 11 months ago by reed1
Modified:
11 years, 11 months ago
Reviewers:
robertphillips
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

unify how we handle externally-provided storage in SkWriter32, with the goal of simplifying the logic in reserve() so it can be inlined/accelerated. Committed: https://code.google.com/p/skia/source/detail?r=6923

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -155 lines) Patch
M include/core/SkWriter32.h View 3 chunks +81 lines, -26 lines 0 comments Download
M src/core/SkWriter32.cpp View 11 chunks +17 lines, -125 lines 0 comments Download
M tests/Writer32Test.cpp View 3 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 3
reed1
will get some bench numbers next
11 years, 11 months ago (2012-12-19 17:51:33 UTC) #1
reed1
profiling shows 5-10% is gone by having reserve() inlined. Total times (on my mac proc) ...
11 years, 11 months ago (2012-12-19 18:28:49 UTC) #2
robertphillips
11 years, 11 months ago (2012-12-19 19:04:59 UTC) #3
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b