Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(8)

Issue 6949071: change all patheffect methods to const, in preparation for marking its (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years ago by reed1
Modified:
12 years ago
Reviewers:
DerekS
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

change all patheffect methods to const, in preparation for marking its subclasses as immutable/re-entrant safe. Committed: https://code.google.com/p/skia/source/detail?r=6877

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -65 lines) Patch
M include/core/SkPathEffect.h View 3 chunks +7 lines, -4 lines 0 comments Download
M include/effects/Sk1DPathEffect.h View 3 chunks +8 lines, -6 lines 0 comments Download
M include/effects/Sk2DPathEffect.h View 4 chunks +10 lines, -9 lines 0 comments Download
M include/effects/SkCornerPathEffect.h View 1 chunk +2 lines, -3 lines 0 comments Download
M include/effects/SkDashPathEffect.h View 1 chunk +6 lines, -5 lines 0 comments Download
M include/effects/SkDiscretePathEffect.h View 1 chunk +2 lines, -1 line 0 comments Download
M samplecode/ClockFaceView.cpp View 2 chunks +8 lines, -7 lines 0 comments Download
M src/animator/SkDrawExtraPathEffect.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M src/core/SkPathEffect.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/effects/Sk1DPathEffect.cpp View 4 chunks +5 lines, -4 lines 0 comments Download
M src/effects/Sk2DPathEffect.cpp View 6 chunks +11 lines, -8 lines 0 comments Download
M src/effects/SkCornerPathEffect.cpp View 2 chunks +4 lines, -9 lines 0 comments Download
M src/effects/SkDashPathEffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkDiscretePathEffect.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
reed1
12 years ago (2012-12-18 15:08:11 UTC) #1
DerekS
lgtm (as long as it compiles)
12 years ago (2012-12-18 16:11:19 UTC) #2
reed1
it needs to compile?!
12 years ago (2012-12-18 16:11:58 UTC) #3
DerekS
12 years ago (2012-12-18 16:13:31 UTC) #4
Message was sent while issue was closed.
only if you value Eric's sanity.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b