Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(535)

Issue 6949070: Fixes pinyin.xml (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 3 months ago by Peng Wu
Modified:
6 years, 2 months ago
Reviewers:
hsumita1, shawn.p.huang, Peng
Base URL:
git://github.com/ibus/ibus-pinyin.git@master
Visibility:
Public.

Description

Fixes pinyin.xml * Change the keyboard layout from us to default; * Update the symbols same as the icons; BUG=

Patch Set 1 #

Patch Set 2 : add more details to git change log #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M src/pinyin.xml.in.in View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 5
Peng
Could you please put more detail in git change log?
11 years, 3 months ago (2012-12-18 03:16:47 UTC) #1
Peng Wu
On 2012/12/18 03:16:47, Peng wrote: > Could you please put more detail in git change ...
11 years, 3 months ago (2012-12-18 03:45:34 UTC) #2
Peng
On 2012/12/18 03:45:34, Peng Wu wrote: > On 2012/12/18 03:16:47, Peng wrote: > > Could ...
11 years, 3 months ago (2012-12-18 13:03:44 UTC) #3
Peng Wu
On 2012/12/18 13:03:44, Peng wrote: > You need update the log in http://codereview.appspot.com. > Press ...
11 years, 3 months ago (2012-12-19 02:53:36 UTC) #4
Peng
11 years, 3 months ago (2012-12-19 04:38:10 UTC) #5
On 2012/12/19 02:53:36, Peng Wu wrote:
> On 2012/12/18 13:03:44, Peng wrote:
> > You need update the log in http://codereview.appspot.com.
> > Press edit, and update the cl description (changelog),
> 
> Sorry, updated again.

Lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b