Accelerate AA filled rect drawing using drawIndexedInstances

This is an alternate method of accelerating AA fill rect drawing than https://codereview.appspot.com/6940060/.

BEFORE:
    aarects  8888: msecs =  23.64   GPU: msecs =  94.26
AFTER:
    aarects  8888: msecs =  23.80   GPU: msecs =  32.24
Which is equivalent to the speedup seen in the old CL.

[robertphillips, 2012-12-18 20:55:49]

https://codereview.appspot.com/6947078/diff/1/src/gpu/GrInOrderDrawBuffer.cpp
File src/gpu/GrInOrderDrawBuffer.cpp (right):

https://codereview.appspot.com/6947078/diff/1/src/gpu/GrInOrderDrawBuffer.cpp...
src/gpu/GrInOrderDrawBuffer.cpp:349: draw->fVertexCount = 0;
fIndexCount wasn't being set before so I reordered all the members to match the
struct's order

[bsalomon, 2012-12-18 21:05:50]

I like this a lot better.. it's much more localized.

https://codereview.appspot.com/6947078/diff/1/include/gpu/GrAARectRenderer.h
File include/gpu/GrAARectRenderer.h (right):

https://codereview.appspot.com/6947078/diff/1/include/gpu/GrAARectRenderer.h#...
include/gpu/GrAARectRenderer.h:57: static const int kIndicesPerAAFillRect = 30;
Do these consts and arrays need to be defined in the header?

If we define kIndicesPerAAFillRect in the cpp it could be make to be the size of
the array:

static const int kIndicesPerAAFillRect = GR_ARRAY_COUNT(gFillAARectIdx);

https://codereview.appspot.com/6947078/diff/1/src/gpu/GrAARectRenderer.cpp
File src/gpu/GrAARectRenderer.cpp (right):

https://codereview.appspot.com/6947078/diff/1/src/gpu/GrAARectRenderer.cpp#ne...
src/gpu/GrAARectRenderer.cpp:71: GrSafeSetNull(fAAFillRectIndexBuffer);
Good thing we safe set NULL before crashing! :)

https://codereview.appspot.com/6947078/diff/1/src/gpu/GrInOrderDrawBuffer.cpp
File src/gpu/GrInOrderDrawBuffer.cpp (right):

https://codereview.appspot.com/6947078/diff/1/src/gpu/GrInOrderDrawBuffer.cpp...
src/gpu/GrInOrderDrawBuffer.cpp:349: draw->fVertexCount = 0;
On 2012/12/18 20:55:49, robertphillips wrote:
> fIndexCount wasn't being set before so I reordered all the members to match
the
> struct's order
nice catch

[robertphillips, 2012-12-18 21:26:49]

https://codereview.appspot.com/6947078/diff/1/include/gpu/GrAARectRenderer.h
File include/gpu/GrAARectRenderer.h (right):

https://codereview.appspot.com/6947078/diff/1/include/gpu/GrAARectRenderer.h#...
include/gpu/GrAARectRenderer.h:57: static const int kIndicesPerAAFillRect = 30;
On 2012/12/18 21:05:50, bsalomon wrote:
> Do these consts and arrays need to be defined in the header?
> 
> If we define kIndicesPerAAFillRect in the cpp it could be make to be the size
of
> the array:
> 
> static const int kIndicesPerAAFillRect = GR_ARRAY_COUNT(gFillAARectIdx);
> 

Done.

https://codereview.appspot.com/6947078/diff/1/src/gpu/GrAARectRenderer.cpp
File src/gpu/GrAARectRenderer.cpp (right):

https://codereview.appspot.com/6947078/diff/1/src/gpu/GrAARectRenderer.cpp#ne...
src/gpu/GrAARectRenderer.cpp:71: GrSafeSetNull(fAAFillRectIndexBuffer);
On 2012/12/18 21:05:50, bsalomon wrote:
> Good thing we safe set NULL before crashing! :)

Done.

[bsalomon, 2012-12-18 21:31:40]

LGTM

https://codereview.appspot.com/6947078/diff/6001/include/gpu/GrAARectRenderer.h
File include/gpu/GrAARectRenderer.h (right):

https://codereview.appspot.com/6947078/diff/6001/include/gpu/GrAARectRenderer...
include/gpu/GrAARectRenderer.h:57: static const int kIndicesPerAAFillRect;
I was thinking that these (and the g...Idx[] arrays) don't even have to be
declared here as members but rather could be defined as statics/anony-namespace
in the cpp.

[robertphillips, 2012-12-18 21:48:14]

committed as r6889

https://codereview.appspot.com/6947078/diff/6001/include/gpu/GrAARectRenderer.h
File include/gpu/GrAARectRenderer.h (right):

https://codereview.appspot.com/6947078/diff/6001/include/gpu/GrAARectRenderer...
include/gpu/GrAARectRenderer.h:57: static const int kIndicesPerAAFillRect;
On 2012/12/18 21:31:40, bsalomon wrote:
> I was thinking that these (and the g...Idx[] arrays) don't even have to be
> declared here as members but rather could be defined as
statics/anony-namespace
> in the cpp.

Done.