Issue 6947075: Fix drawSprite to record correctly with SkBBoxRecord

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6947075: Fix drawSprite to record correctly with SkBBoxRecord (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 6 months ago by junov1

Modified:
11 years, 6 months ago

Reviewers:
reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Fix drawSprite to record correctly with SkBBoxRecord BUG=http://code.google.com/p/skia/issues/detail?id=1014 TEST=gm lighting with -tileGrid Committed: https://code.google.com/p/skia/source/detail?r=6876

Patch Set 1 #

Total comments: 1

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/core/SkBBoxRecord.cpp	View		1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

reed1

11 years, 6 months ago (2012-12-17 22:44:57 UTC) #2

good catch.

lgtm w/ line-wrap nit

https://codereview.appspot.com/6947075/diff/1/src/core/SkBBoxRecord.cpp
File src/core/SkBBoxRecord.cpp (left):

https://codereview.appspot.com/6947075/diff/1/src/core/SkBBoxRecord.cpp#oldco...
src/core/SkBBoxRecord.cpp:213: const SkPaint* paint) {
better line-wrap?

one option:

bbox.set(SkIRect::MakeXYWH(left, top, bitmap.width(), bitmap.height()));

Expand All Messages | Collapse All Messages