Issue 6947072: Allow setting a scaleFactor in bench_pictures (and render_pictures).

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6947072: Allow setting a scaleFactor in bench_pictures (and render_pictures). (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 6 months ago by Leon

Modified:
11 years, 6 months ago

Reviewers:
EricB, DerekS, reed1

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Allow setting a scaleFactor in bench_pictures (and render_pictures). In TiledPictureRenderer and CopyTilesRenderer, do a postTranslate so the translate is not affected by the scale factor. Likewise, use clipRegion for tiled renderer so it will be unaffected by the scale factor. Respect the viewport for record, playbackCreation, and pipe renderers. Committed: https://code.google.com/p/skia/source/detail?r=6853

Patch Set 1 #

Patch Set 2 : Small cleanups: limit to 100 chars and use gLogger + macro to exit. #

Total comments: 2

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+72 lines, -20 lines)			Patch
M	tools/CopyTilesRenderer.cpp	View	1	1 chunk	+6 lines, -1 line	0 comments	Download
M	tools/PictureRenderer.h	View		4 chunks	+12 lines, -0 lines	2 comments	Download
M	tools/PictureRenderer.cpp	View		6 chunks	+31 lines, -17 lines	0 comments	Download
M	tools/bench_pictures_main.cpp	View	1	5 chunks	+11 lines, -1 line	0 comments	Download
M	tools/render_pictures_main.cpp	View		5 chunks	+12 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

DerekS

lgtm, but perhaps mike should verify that the postTranslate stuff is correct. https://codereview.appspot.com/6947072/diff/2001/tools/PictureRenderer.h File tools/PictureRenderer.h ...

11 years, 6 months ago (2012-12-17 19:04:46 UTC) #2

Leon

11 years, 6 months ago (2012-12-17 19:25:28 UTC) #3

Mike agrees with the math, and render_pictures gives me the expected result.

https://codereview.appspot.com/6947072/diff/2001/tools/PictureRenderer.h
File tools/PictureRenderer.h (right):

https://codereview.appspot.com/6947072/diff/2001/tools/PictureRenderer.h#newc...
tools/PictureRenderer.h:228: void scaleToScaleFactor(SkCanvas*);
On 2012/12/17 19:04:46, DerekS wrote:
> could this be simplified to just scaleCanvas?

As we discussed, I kind of like the current name, since it hints that we're
scaling by a particular amount.

Expand All Messages | Collapse All Messages