Issue 6946052: Fix bench_pictures.cfg and add sanity check

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6946052: Fix bench_pictures.cfg and add sanity check (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 11 months ago by EricB

Modified:
11 years, 11 months ago

Reviewers:
epoger, rmistry

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Fix bench_pictures.cfg and add sanity check Committed: https://code.google.com/p/skia/source/detail?r=6822

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+81 lines, -8 lines)			Patch
M	tools/bench_pictures.cfg	View		1 chunk	+6 lines, -6 lines	1 comment	Download
M	tools/bench_pictures_cfg_helper.py	View		1 chunk	+39 lines, -2 lines	0 comments	Download
A	tools/tests/bench_pictures_cfg_test.py	View	1	1 chunk	+36 lines, -0 lines	1 comment	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

EricB

TBR'ing this to get it submitted before leaving for offsite. Should fix bench bots and, ...

11 years, 11 months ago (2012-12-14 14:56:49 UTC) #1

epoger

11 years, 11 months ago (2012-12-14 17:59:23 UTC) #2

Message was sent while issue was closed.

LGTM with some cleanup suggestions

https://codereview.appspot.com/6946052/diff/2001/tools/bench_pictures.cfg
File tools/bench_pictures.cfg (right):

https://codereview.appspot.com/6946052/diff/2001/tools/bench_pictures.cfg#new...
tools/bench_pictures.cfg:58: RecordRTreeConfig(DEFAULT_TILE_X, DEFAULT_TILE_Y),
This would be easier to read if the lines lined up like so:

RecordRTreeConfig(           DEFAULT_TILE_X, DEFAULT_TILE_Y),
PlaybackCreationRTreeConfig( DEFAULT_TILE_X, DEFAULT_TILE_Y),
...etc

https://codereview.appspot.com/6946052/diff/2001/tools/tests/bench_pictures_c...
File tools/tests/bench_pictures_cfg_test.py (right):

https://codereview.appspot.com/6946052/diff/2001/tools/tests/bench_pictures_c...
tools/tests/bench_pictures_cfg_test.py:22: raise TypeError('%s is not a string!'
% str(config_name))
I think this would be cleaner:

ThrowIfNotAString(config_name)
ThrowIfNotAString(key)
...etc

def ThrowIfNotAString(obj):
  if str(obj) != obj:
    raise TypeError('%s is not a string!\n%s' % (str(obj), obj))

Expand All Messages | Collapse All Messages