Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(165)

Issue 6944062: Fixing bounding box computation for inverse filled patch ing SkBBoxRecord (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 10 months ago by junov1
Modified:
11 years, 10 months ago
Reviewers:
reed1
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Fixing bounding box computation for inverse filled paths in SkBBoxRecord BUG=http://code.google.com/p/skia/issues/detail?id=1014 TEST=gm emptypath with --tileGrid Committed: https://code.google.com/p/skia/source/detail?r=6865

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M src/core/SkBBoxRecord.cpp View 1 2 1 chunk +9 lines, -1 line 0 comments Download

Messages

Total messages: 4
junov1
PTAL
11 years, 10 months ago (2012-12-17 20:31:03 UTC) #1
reed1
https://codereview.appspot.com/6944062/diff/2001/src/core/SkBBoxRecord.cpp File src/core/SkBBoxRecord.cpp (right): https://codereview.appspot.com/6944062/diff/2001/src/core/SkBBoxRecord.cpp#newcode33 src/core/SkBBoxRecord.cpp:33: SkRect clipBounds; getClipBounds returns in local coordinates. getClipDeviceBounds returns ...
11 years, 10 months ago (2012-12-17 20:40:21 UTC) #2
junov1
Good catch. New patch.
11 years, 10 months ago (2012-12-17 21:14:23 UTC) #3
reed1
11 years, 10 months ago (2012-12-17 21:27:12 UTC) #4
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b