Re-land r6843 with copied gyp file to (hopefully) fix Windows build
BUG=https://code.google.com/p/skia/issues/detail?id=1023
Committed: https://code.google.com/p/skia/source/detail?r=6880
Patchset 1 reapplies r6843 as it was originally. It works fine on my Linux machine, ...
11 years, 12 months ago
(2012-12-18 17:53:44 UTC)
#1
Patchset 1 reapplies r6843 as it was originally. It works fine on my Linux
machine, but would presumably fail on the Windows production bots like it did
yesterday.
Patchset 1 was already approved by Eric in https://codereview.appspot.com/6940053/ ('Add --writeJsonSummary option to gm') Please ...
11 years, 12 months ago
(2012-12-18 18:14:32 UTC)
#2
Patchset 1 was already approved by Eric in
https://codereview.appspot.com/6940053/ ('Add --writeJsonSummary option to gm')
Please review patchset 2, in which I copy jsoncpp's gyp into our our gyp
directory. I have confirmed that this works on my Linux machine, and I suspect
it will work on the Windows bots.
On 2012/12/18 18:14:32, epoger wrote: > Patchset 1 was already approved by Eric in > ...
11 years, 12 months ago
(2012-12-18 18:14:58 UTC)
#3
On 2012/12/18 18:14:32, epoger wrote:
> Patchset 1 was already approved by Eric in
> https://codereview.appspot.com/6940053/ ('Add --writeJsonSummary option to
gm')
>
> Please review patchset 2, in which I copy jsoncpp's gyp into our our gyp
> directory. I have confirmed that this works on my Linux machine, and I
suspect
> it will work on the Windows bots.
(i.e. please review the DIFFERENCE between patchsets 1 and 2)
Issue 6943073: Re-land r6843 with copied gyp file to (hopefully) fix Windows build
(Closed)
Created 11 years, 12 months ago by epoger
Modified 11 years, 12 months ago
Reviewers: DerekS
Base URL: http://skia.googlecode.com/svn/trunk/
Comments: 0