Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3551)

Issue 6943073: Re-land r6843 with copied gyp file to (hopefully) fix Windows build (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 10 months ago by epoger
Modified:
11 years, 10 months ago
Reviewers:
DerekS
CC:
skia-review_googlegroups.com, EricB
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Re-land r6843 with copied gyp file to (hopefully) fix Windows build BUG=https://code.google.com/p/skia/issues/detail?id=1023 Committed: https://code.google.com/p/skia/source/detail?r=6880

Patch Set 1 #

Patch Set 2 : copy_jsoncpp.gyp_to_our_gyp_dir #

Unified diffs Side-by-side diffs Delta from patch set Stats (+139 lines, -2 lines) Patch
M gm/gmmain.cpp View 9 chunks +81 lines, -7 lines 0 comments Download
A + gm/tests/inputs/empty-dir/README View 0 chunks +-1 lines, --1 lines 0 comments Download
M gm/tests/outputs/compared-against-different-pixels/output-expected/command_line View 1 chunk +1 line, -1 line 0 comments Download
A + gm/tests/outputs/compared-against-different-pixels/output-expected/json-summary.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + gm/tests/outputs/compared-against-empty-dir/output-expected/command_line View 0 chunks +-1 lines, --1 lines 0 comments Download
A + gm/tests/outputs/compared-against-empty-dir/output-expected/images/8888/dashing2.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + gm/tests/outputs/compared-against-empty-dir/output-expected/json-summary.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + gm/tests/outputs/compared-against-empty-dir/output-expected/return_value View 0 chunks +-1 lines, --1 lines 0 comments Download
A + gm/tests/outputs/compared-against-empty-dir/output-expected/stdout View 0 chunks +-1 lines, --1 lines 0 comments Download
M gm/tests/outputs/compared-against-identical-bytes/output-expected/command_line View 1 chunk +1 line, -1 line 0 comments Download
A + gm/tests/outputs/compared-against-identical-bytes/output-expected/json-summary.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M gm/tests/outputs/compared-against-identical-pixels/output-expected/command_line View 1 chunk +1 line, -1 line 0 comments Download
A + gm/tests/outputs/compared-against-identical-pixels/output-expected/json-summary.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M gm/tests/run.sh View 3 chunks +5 lines, -1 line 0 comments Download
M gyp/gm.gyp View 1 2 chunks +3 lines, -0 lines 0 comments Download
A gyp/jsoncpp.gyp View 1 1 chunk +56 lines, -0 lines 0 comments Download

Messages

Total messages: 4
epoger
Patchset 1 reapplies r6843 as it was originally. It works fine on my Linux machine, ...
11 years, 10 months ago (2012-12-18 17:53:44 UTC) #1
epoger
Patchset 1 was already approved by Eric in https://codereview.appspot.com/6940053/ ('Add --writeJsonSummary option to gm') Please ...
11 years, 10 months ago (2012-12-18 18:14:32 UTC) #2
epoger
On 2012/12/18 18:14:32, epoger wrote: > Patchset 1 was already approved by Eric in > ...
11 years, 10 months ago (2012-12-18 18:14:58 UTC) #3
DerekS
11 years, 10 months ago (2012-12-18 19:05:59 UTC) #4
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b