On 2012/12/18 14:54:14, dgkoch wrote: > What necessitated turning optimizations off this time? > > ...
11 years, 4 months ago
(2012-12-19 00:51:04 UTC)
#4
Message was sent while issue was closed.
On 2012/12/18 14:54:14, dgkoch wrote:
> What necessitated turning optimizations off this time?
>
> Would be good to have a record of this somewhere so we know what to test, etc.
Some of MapsGL's shaders were causing 10-second-long compiles, and Chrome's GPU
sub-process to be killed. The issue's being tracked under multiple bugs and
email threads within Google so it's unlikely to get lost.
Some complex shaders fail to compile if optimizations are disabled. So perhaps we should first ...
11 years, 4 months ago
(2012-12-19 14:23:47 UTC)
#5
Message was sent while issue was closed.
Some complex shaders fail to compile if optimizations are disabled. So perhaps
we should first try compiling without optimizations and if that fails try with
optimizations. This can easily be done by adding another option to the flags
list in ProgramBinary::compileToBinary. By adding a descriptive warning in the
info log, application developers can try to simplify their shaders so it
compiles faster.
On 2012/12/19 14:23:47, nicolas wrote: > Some complex shaders fail to compile if optimizations are ...
11 years, 4 months ago
(2012-12-19 18:55:03 UTC)
#6
Message was sent while issue was closed.
On 2012/12/19 14:23:47, nicolas wrote:
> Some complex shaders fail to compile if optimizations are disabled. So perhaps
> we should first try compiling without optimizations and if that fails try with
> optimizations. This can easily be done by adding another option to the flags
> list in ProgramBinary::compileToBinary. By adding a descriptive warning in the
> info log, application developers can try to simplify their shaders so it
> compiles faster.
It's worse than that. Some complex shaders successfully compile with
optimizations disabled but the resulting binary is invalid. I think we need a
compiler that we can fix when bugs come up.
Issue 6943062: Use shader D3D optimization level 0.
(Closed)
Created 11 years, 4 months ago by apatrick1
Modified 11 years, 4 months ago
Reviewers: VangelisK, vangelis, dgkoch, kbr1, nicolas
Base URL: http://angleproject.googlecode.com/svn/trunk/
Comments: 0