Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(97)

Issue 6943062: Use shader D3D optimization level 0. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 4 months ago by apatrick1
Modified:
11 years, 4 months ago
CC:
angleproject-review_googlegroups.com
Base URL:
http://angleproject.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Use shader D3D optimization level 0. Committed: https://code.google.com/p/angleproject/source/detail?r=1562

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/build_angle.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M src/common/version.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6
apatrick1
11 years, 4 months ago (2012-12-14 23:19:29 UTC) #1
vangelis
On 2012/12/14 23:19:29, apatrick1 wrote: LGTM
11 years, 4 months ago (2012-12-14 23:33:59 UTC) #2
dgkoch
What necessitated turning optimizations off this time? Would be good to have a record of ...
11 years, 4 months ago (2012-12-18 14:54:14 UTC) #3
kbr1
On 2012/12/18 14:54:14, dgkoch wrote: > What necessitated turning optimizations off this time? > > ...
11 years, 4 months ago (2012-12-19 00:51:04 UTC) #4
nicolas
Some complex shaders fail to compile if optimizations are disabled. So perhaps we should first ...
11 years, 4 months ago (2012-12-19 14:23:47 UTC) #5
apatrick1
11 years, 4 months ago (2012-12-19 18:55:03 UTC) #6
Message was sent while issue was closed.
On 2012/12/19 14:23:47, nicolas wrote:
> Some complex shaders fail to compile if optimizations are disabled. So perhaps
> we should first try compiling without optimizations and if that fails try with
> optimizations. This can easily be done by adding another option to the flags
> list in ProgramBinary::compileToBinary. By adding a descriptive warning in the
> info log, application developers can try to simplify their shaders so it
> compiles faster.

It's worse than that. Some complex shaders successfully compile with
optimizations disabled but the resulting binary is invalid. I think we need a
compiler that we can fix when bugs come up.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b