Issue 6943052: Allow bench_pictures to have its viewport set on the command line.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6943052: Allow bench_pictures to have its viewport set on the command line. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years ago by Leon

Modified:
12 years ago

Reviewers:
EricB, DerekS

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Allow bench_pictures to have its viewport set on the command line. Instead of drawing the entire (potentially very large) picture, only draw one viewport's worth. example: bench_pictures <skp directory> --viewport 640 480 BUG=https://code.google.com/p/skia/issues/detail?id=1007 Committed: https://code.google.com/p/skia/source/detail?r=6799

Patch Set 1 #

Created: 12 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+112 lines, -26 lines)			Patch
M	tools/CopyTilesRenderer.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	tools/PictureRenderer.h	View	2 chunks	+33 lines, -12 lines	0 comments	Download
M	tools/PictureRenderer.cpp	View	5 chunks	+39 lines, -11 lines	0 comments	Download
M	tools/bench_pictures_main.cpp	View	5 chunks	+18 lines, -0 lines	0 comments	Download
M	tools/render_pictures_main.cpp	View	5 chunks	+20 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

On 2012/12/13 21:23:39, DerekS wrote:
> lgtm

LGTM2

Expand All Messages | Collapse All Messages