Issue 69430043: Add parse_constraints and check_constraints.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 69430043: Add parse_constraints and check_constraints.

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 2 months ago by bac

Modified:
10 years, 1 month ago

Reviewers:
rharding, Marco Ceppi, mp+208669

Visibility:
Public.

Description

Add parse_constraints and check_constraints. Also, removes the dependency on ez_setup since it caused the package to not build and was unnecessary. There is a real system dependency on python-virtualenv which install python-setuptools, so setuptools will always be available and ez_setup not required. https://code.launchpad.net/~bac/charmworldlib/check-constraints/+merge/208669 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Add parse_constraints and check_constraints. #

Patch Set 3 : Add parse_constraints and check_constraints. #

Total comments: 2

Patch Set 4 : Add parse_constraints and check_constraints. #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+213 lines, -370 lines)			Patch
M	Makefile	View		3 chunks	+5 lines, -1 line	0 comments	Download
A	[revision details]	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download
M	charmworldlib/bundle.py	View	1	1 chunk	+1 line, -1 line	0 comments	Download
A	charmworldlib/utils.py	View	1 2 3	1 chunk	+76 lines, -0 lines	0 comments	Download
D	ez_setup.py	View		1 chunk	+0 lines, -361 lines	0 comments	Download
M	setup.py	View	1 2 3	1 chunk	+1 line, -6 lines	0 comments	Download
M	tests/test_bundle.py	View	1	1 chunk	+4 lines, -1 line	0 comments	Download
A	tests/test_utils.py	View	1 2 3	1 chunk	+124 lines, -0 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

rharding

LGTM thanks for the update and sanity checking. https://codereview.appspot.com/69430043/diff/40001/setup.py File setup.py (right): https://codereview.appspot.com/69430043/diff/40001/setup.py#newcode13 setup.py:13: version="0.2.4-2-bac", ...

10 years, 1 month ago (2014-02-28 14:42:11 UTC) #4

bac

Please take a look. https://codereview.appspot.com/69430043/diff/40001/setup.py File setup.py (right): https://codereview.appspot.com/69430043/diff/40001/setup.py#newcode13 setup.py:13: version="0.2.4-2-bac", On 2014/02/28 14:42:11, rharding ...

10 years, 1 month ago (2014-03-04 13:50:37 UTC) #5

LGTM

Expand All Messages | Collapse All Messages