Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(50)

Issue 6942048: In the config name, report the viewport, if one is provided. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 10 months ago by Leon
Modified:
11 years, 10 months ago
Reviewers:
EricB, benchen
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlecode.com/svn/trunk
Visibility:
Public.

Description

In the config name, report the viewport, if one is provided. Committed: https://code.google.com/p/skia/source/detail?r=6804

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M tools/PictureRenderer.h View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 2
Leon
The config name is getting a little clunky... Maybe that's okay though? Is there some ...
11 years, 10 months ago (2012-12-13 22:00:42 UTC) #1
EricB
11 years, 10 months ago (2012-12-13 22:02:54 UTC) #2
On 2012/12/13 22:00:42, scroggo-work wrote:
> The config name is getting a little clunky... Maybe that's okay though? Is
there
> some other, better way to differentiate between modes? The important thing is
to
> be able to recognize when we're comparing results from two modes with the same
> viewport (and when we're not).

Good catch.  Maybe the eventual best thing to do is to write out csv, json, or
xml instead?

LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b