Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(290)

Issue 6941072: Adding gm test steps for rtree and tileGrid (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 8 months ago by junov1
Modified:
11 years, 8 months ago
Reviewers:
EricB
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Adding gm test steps for rtree and tileGrid The new passes are enabled by default, and can be disabled with --nortree and --notileGrid. With this change, the skia buildbots will begin continuously testing rtree and tileGrid. BUG=http://code.google.com/p/skia/issues/detail?id=1014 TEST=gm Committed: https://code.google.com/p/skia/source/detail?r=6886

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -10 lines) Patch
M gm/gm.h View 1 chunk +0 lines, -2 lines 1 comment Download
M gm/gmmain.cpp View 5 chunks +35 lines, -8 lines 2 comments Download

Messages

Total messages: 4
junov1
PTAL https://codereview.appspot.com/6941072/diff/1/gm/gm.h File gm/gm.h (left): https://codereview.appspot.com/6941072/diff/1/gm/gm.h#oldcode42 gm/gm.h:42: kRTree_Flag = 1 << 5, Cleanup: these flags ...
11 years, 8 months ago (2012-12-18 20:48:48 UTC) #1
EricB
LGTM with nit. Have these been fixed, or will the bots start failing once this ...
11 years, 8 months ago (2012-12-18 20:55:52 UTC) #2
junov1
On 2012/12/18 20:55:52, EricB wrote: > LGTM with nit. Have these been fixed, or will ...
11 years, 8 months ago (2012-12-18 21:07:14 UTC) #3
EricB
11 years, 8 months ago (2012-12-18 21:08:23 UTC) #4
On 2012/12/18 21:07:14, junov1 wrote:
> On 2012/12/18 20:55:52, EricB wrote:
> > LGTM with nit.  Have these been fixed, or will the bots start failing once
> this
> > is committed?
> 
> They've been fixed.
> See: http://code.google.com/p/skia/issues/detail?id=1014

Great!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b