Mark all methods on SkXfermode as const, in preparation for declaring all

Mark all methods on SkXfermode as const, in preparation for declaring all
xfermodes as immutable/reentrant-safe
Committed: https://code.google.com/p/skia/source/detail?r=6855

[Leon, 2012-12-17 19:35:01]

lgtm

https://codereview.appspot.com/6941065/diff/1/include/core/SkXfermode.h
File include/core/SkXfermode.h (right):

https://codereview.appspot.com/6941065/diff/1/include/core/SkXfermode.h#newco...
include/core/SkXfermode.h:18: SkXfermode is the base class for objects that are
called to implement custom
Should we add a comment that SkXfermodes are immutable?

https://codereview.appspot.com/6941065/diff/1/include/core/SkXfermode.h#newco...
include/core/SkXfermode.h:150: static SkXfermode* Create(Mode mode);
Maybe overkill, but should we return a const SkXfermode?

https://codereview.appspot.com/6941065/diff/1/include/effects/SkAvoidXfermode.h
File include/effects/SkAvoidXfermode.h (right):

https://codereview.appspot.com/6941065/diff/1/include/effects/SkAvoidXfermode...
include/effects/SkAvoidXfermode.h:59: SkColor     fOpColor;
Should these be marked const?

[Leon, 2012-12-17 19:36:20]

On 2012/12/17 19:35:01, scroggo-work wrote:
> lgtm
> 
> https://codereview.appspot.com/6941065/diff/1/include/core/SkXfermode.h
> File include/core/SkXfermode.h (right):
> 
>
https://codereview.appspot.com/6941065/diff/1/include/core/SkXfermode.h#newco...
> include/core/SkXfermode.h:18: SkXfermode is the base class for objects that
are
> called to implement custom
> Should we add a comment that SkXfermodes are immutable?
> 
>
https://codereview.appspot.com/6941065/diff/1/include/core/SkXfermode.h#newco...
> include/core/SkXfermode.h:150: static SkXfermode* Create(Mode mode);
> Maybe overkill, but should we return a const SkXfermode?
> 
>
https://codereview.appspot.com/6941065/diff/1/include/effects/SkAvoidXfermode.h
> File include/effects/SkAvoidXfermode.h (right):
> 
>
https://codereview.appspot.com/6941065/diff/1/include/effects/SkAvoidXfermode...
> include/effects/SkAvoidXfermode.h:59: SkColor     fOpColor;
> Should these be marked const?

Oops, just looked at the description again, and it sounds like all of my
comments would be part of a next step (what this one is preparing for).

LGTM

[DerekS, 2012-12-17 19:40:02]

lgtm