Issue 6941051: Use Variant.unpack() instead of Variant.dup_strv().

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6941051: Use Variant.unpack() instead of Variant.dup_strv(). (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 4 months ago by fujiwara

Modified:
11 years, 4 months ago

Reviewers:
shawn.p.huang, Peng

CC:
shawn.p.huang_gmail.com

Base URL:
git://github.com/ibus/ibus.git@master

Visibility:
Public.

More Reviews

Description

Use Variant.unpack() instead of Variant.dup_strv(). Variant.dup_strv() returns a tuple in pygobject 3.2, e.g. (['<Control>space'], 1L), and a list in pygobject 3.4, e.g. ['<Control>space'] . BUG=RH#887153

Patch Set 1 #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	setup/main.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Peng

Do not understand why need it? Could add more info in git log?

11 years, 4 months ago (2012-12-14 13:29:04 UTC) #2

fujiwara

On 2012/12/14 13:29:04, Peng wrote: > Do not understand why need it? Could add more ...

11 years, 4 months ago (2012-12-14 22:39:33 UTC) #3

Peng

11 years, 4 months ago (2012-12-15 03:55:31 UTC) #4

On 2012/12/14 22:39:33, fujiwara wrote:
> On 2012/12/14 13:29:04, Peng wrote:
> > Do not understand why need it? Could add more info in git log?
> 
> Done.

lgtm

Expand All Messages | Collapse All Messages