Slave Build Step to render pdfs. At the moment I am only looking for assertions, so we throw away r…

Slave Build Step to render pdfs. At the moment I am only looking for assertions, so we throw away rendered pdfs.

[EricB, 2012-12-18 19:48:01]

This looks fine, but we also need versions for android and chrome os.  Check out
android_render_pictures.py and chromeos_render_pictures.py.

[epoger, 2012-12-18 20:35:02]

https://codereview.appspot.com/6940081/diff/1/slave/skia_slave_scripts/render...
File slave/skia_slave_scripts/render_pdfs.py (right):

https://codereview.appspot.com/6940081/diff/1/slave/skia_slave_scripts/render...
slave/skia_slave_scripts/render_pdfs.py:15: class RenderPdfs(BuildStep):
Is there some good reason that the "gm" binary produces both PNGs and PDFs, but
when rendering SKPs we need separate "render_pictures" and "render_pdfs"
binaries?

gm:
https://code.google.com/p/skia/source/browse/trunk/gm/gmmain.cpp

render_pictures and render_pdfs:
https://code.google.com/p/skia/source/browse/trunk/tools/render_pictures_main...
https://code.google.com/p/skia/source/browse/trunk/tools/render_pdfs_main.cpp

https://codereview.appspot.com/6940081/diff/1/slave/skia_slave_scripts/render...
slave/skia_slave_scripts/render_pdfs.py:27: # Throw away pdfs, we are interested
now only in asserts.
On some platforms, writing out the files takes a significant amount of time.  So
it would be better to call render_pdfs in such a way that it doesn't bother
writing out its results.

If render_pdfs doesn't support that, it should.

[edisonn, 2013-01-11 20:33:57]

https://codereview.appspot.com/6940081/diff/1/slave/skia_slave_scripts/render...
File slave/skia_slave_scripts/render_pdfs.py (right):

https://codereview.appspot.com/6940081/diff/1/slave/skia_slave_scripts/render...
slave/skia_slave_scripts/render_pdfs.py:15: class RenderPdfs(BuildStep):
render_pdf and render_pictures have widely different parameters and I would not
want to combine them, it would make code much harder to read

On 2012/12/18 20:35:02, epoger wrote:
> Is there some good reason that the "gm" binary produces both PNGs and PDFs,
but
> when rendering SKPs we need separate "render_pictures" and "render_pdfs"
> binaries?
> 
> gm:
> https://code.google.com/p/skia/source/browse/trunk/gm/gmmain.cpp
> 
> render_pictures and render_pdfs:
>
https://code.google.com/p/skia/source/browse/trunk/tools/render_pictures_main...
> https://code.google.com/p/skia/source/browse/trunk/tools/render_pdfs_main.cpp

https://codereview.appspot.com/6940081/diff/1/slave/skia_slave_scripts/render...
slave/skia_slave_scripts/render_pdfs.py:27: # Throw away pdfs, we are interested
now only in asserts.
submitted change to make render_pdfs support this scenario

On 2012/12/18 20:35:02, epoger wrote:
> On some platforms, writing out the files takes a significant amount of time. 
So
> it would be better to call render_pdfs in such a way that it doesn't bother
> writing out its results.
> 
> If render_pdfs doesn't support that, it should.