Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2210)

Issue 6937077: Adding tileGrid scaled playback capability to gm. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 8 months ago by junov1
Modified:
11 years, 8 months ago
Reviewers:
edisonn, EricB, reed1
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Adding tileGrid scaled playback capability to gm. BUG=http://code.google.com/p/skia/issues/detail?id=1021 Committed: https://code.google.com/p/skia/source/detail?r=6898

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -12 lines) Patch
M gm/gmmain.cpp View 7 chunks +46 lines, -12 lines 1 comment Download

Messages

Total messages: 5
junov1
PTAL
11 years, 8 months ago (2012-12-18 22:07:28 UTC) #1
junov1
On 2012/12/18 22:07:28, junov1 wrote: > PTAL FYI the tests currently have failures with non-one ...
11 years, 8 months ago (2012-12-18 22:11:05 UTC) #2
reed1
... adding Edison
11 years, 8 months ago (2012-12-18 22:19:22 UTC) #3
EricB
LGTM with question. https://codereview.appspot.com/6937077/diff/1/gm/gmmain.cpp File gm/gmmain.cpp (right): https://codereview.appspot.com/6937077/diff/1/gm/gmmain.cpp#newcode1081 gm/gmmain.cpp:1081: ++argv; Would it be better to ...
11 years, 8 months ago (2012-12-19 15:17:19 UTC) #4
junov1
11 years, 8 months ago (2012-12-19 15:21:51 UTC) #5
> Would it be better to error-check here as well?

Totally.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b