Issue 6937066: Adding missing oval primitive to SkBBoxRecord

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6937066: Adding missing oval primitive to SkBBoxRecord (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 9 months ago by junov1

Modified:
11 years, 9 months ago

Reviewers:
reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Adding missing oval and roundedRect primitives to SkBBoxRecord BUG=http://code.google.com/p/skia/issues/detail?id=1014 TEST=gm with --tileGrid Committed: https://code.google.com/p/skia/source/detail?r=6846

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -0 lines)			Patch
	M	src/core/SkBBoxRecord.h	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
	M	src/core/SkBBoxRecord.cpp	View	1	1 chunk	+12 lines, -0 lines	1 comment	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

reed1

11 years, 9 months ago (2012-12-17 16:20:36 UTC) #5

lgtm w/ suggested nit

https://codereview.appspot.com/6937066/diff/5001/src/core/SkBBoxRecord.cpp
File src/core/SkBBoxRecord.cpp (right):

https://codereview.appspot.com/6937066/diff/5001/src/core/SkBBoxRecord.cpp#ne...
src/core/SkBBoxRecord.cpp:16: 
nit: might call this parameter rrect, to match other code and for "slightly"
improved clarity. Not critical.

Expand All Messages | Collapse All Messages