Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(70)

Issue 6937048: Use GrDrawTarget::AutoClipRestore to set temporary irect clips. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 11 months ago by bsalomon
Modified:
11 years, 11 months ago
Reviewers:
robertphillips
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Use GrDrawTarget::AutoClipRestore to set temporary irect clips. R=robertphillips@google.com Committed: https://code.google.com/p/skia/source/detail?r=6793

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -17 lines) Patch
M src/gpu/GrClipMaskManager.cpp View 1 3 chunks +2 lines, -14 lines 0 comments Download
M src/gpu/GrDrawTarget.h View 2 chunks +9 lines, -3 lines 0 comments Download
M src/gpu/GrDrawTarget.cpp View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 3
bsalomon
11 years, 11 months ago (2012-12-13 20:26:20 UTC) #1
robertphillips
LGTM. Are there other instances where a AutoClipRestore with a new SkRect clip (vs. an ...
11 years, 11 months ago (2012-12-13 20:32:13 UTC) #2
bsalomon
11 years, 11 months ago (2012-12-13 20:38:04 UTC) #3
On 2012/12/13 20:32:13, robertphillips wrote:
> LGTM. Are there other instances where a AutoClipRestore with a new SkRect clip
> (vs. an IRect clip) could use a similar pattern?

I searched around and didn't see anything.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b