Issue 6937048: Use GrDrawTarget::AutoClipRestore to set temporary irect clips.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6937048: Use GrDrawTarget::AutoClipRestore to set temporary irect clips. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by bsalomon

Modified:
11 years, 7 months ago

Reviewers:
robertphillips

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Use GrDrawTarget::AutoClipRestore to set temporary irect clips. R=robertphillips@google.com Committed: https://code.google.com/p/skia/source/detail?r=6793

Patch Set 1 #

Patch Set 2 : #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -17 lines)			Patch
M	src/gpu/GrClipMaskManager.cpp	View	1	3 chunks	+2 lines, -14 lines	0 comments	Download
M	src/gpu/GrDrawTarget.h	View		2 chunks	+9 lines, -3 lines	0 comments	Download
M	src/gpu/GrDrawTarget.cpp	View		1 chunk	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

robertphillips

LGTM. Are there other instances where a AutoClipRestore with a new SkRect clip (vs. an ...

11 years, 7 months ago (2012-12-13 20:32:13 UTC) #2

bsalomon

11 years, 7 months ago (2012-12-13 20:38:04 UTC) #3

On 2012/12/13 20:32:13, robertphillips wrote:
> LGTM. Are there other instances where a AutoClipRestore with a new SkRect clip
> (vs. an IRect clip) could use a similar pattern?

I searched around and didn't see anything.

Expand All Messages | Collapse All Messages