Issue 6927054: Minor cleanup

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6927054: Minor cleanup (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years ago by robertphillips

Modified:
12 years ago

Reviewers:
bsalomon

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

These are some minor changes that I would like to keep but were cluttering up the AA rect batching CL. Since I was creating a rather trivial CL I went ahead and added some Windows compiler complaint fixes.

Patch Set 1 #

Total comments: 3

Created: 12 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+42 lines, -42 lines)			Patch
M	bench/DashBench.cpp	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	debugger/QT/SkDebuggerGUI.cpp	View	3 chunks	+3 lines, -3 lines	1 comment	Download
M	gm/modecolorfilters.cpp	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	gm/shadertext3.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	samplecode/SampleFatBits.cpp	View	9 chunks	+16 lines, -16 lines	2 comments	Download
M	src/gpu/GrAARectRenderer.cpp	View	6 chunks	+15 lines, -16 lines	0 comments	Download
M	tests/InfRectTest.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

robertphillips

https://codereview.appspot.com/6927054/diff/1/debugger/QT/SkDebuggerGUI.cpp File debugger/QT/SkDebuggerGUI.cpp (right): https://codereview.appspot.com/6927054/diff/1/debugger/QT/SkDebuggerGUI.cpp#newcode184 debugger/QT/SkDebuggerGUI.cpp:184: The SK_OVERRIDEs cause an error when the stubs aren't ...

12 years ago (2012-12-12 15:53:28 UTC) #1

Message was sent while issue was closed.

committed as r6756

Expand All Messages | Collapse All Messages