code review 6922048: cmd/{5,6,8}g: reduce size of Prog and Addr

src/cmd/6g/peep.c

 // Derived from Inferno utils/6c/peep.c
 // http://code.google.com/p/inferno-os/source/browse/utils/6c/peep.c
 //
 //      Copyright © 1994-1999 Lucent Technologies Inc.  All rights reserved.
 //      Portions Copyright © 1995-1997 C H Forsyth (forsyth@terzarima.net)
 //      Portions Copyright © 1997-1999 Vita Nuova Limited
 //      Portions Copyright © 2000-2007 Vita Nuova Holdings Limited (www.vitanuova.com)
 //      Portions Copyright © 2004,2006 Bruce Ellis
 //      Portions Copyright © 2005-2007 C H Forsyth (forsyth@terzarima.net)
 //      Revisions Copyright © 2000-2007 Lucent Technologies Inc. and others
@@ skipping 1285 matching lines @@
         case 2: // rar
         case 4: // use and set
                 break;
 
         case 3: // set
                 if(p->as == p0->as)
                 if(p->from.type == p0->from.type)
                 if(p->from.node == p0->from.node)
                 if(p->from.offset == p0->from.offset)
                 if(p->from.scale == p0->from.scale)
-                if(p->from.u.dval == p0->from.u.dval)

[rsc, 2012/12/12 04:07:28]

use vval == vval not dval == dval
fp comparison may not do what you want if something else is stored there.

[dave_cheney.net, 2012/12/13 00:23:16]

Done.

+                if(p->from.u.vval == p0->from.u.vval)
                 if(p->from.index == p0->from.index) {
                         excise(r);
                         goto loop;
                 }
                 break;
         }
 }