Issue 6909049: Remove transfer container in ibus_engine_simple_add_table.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6909049: Remove transfer container in ibus_engine_simple_add_table. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 5 months ago by fujiwara

Modified:
11 years, 5 months ago

Reviewers:
shawn.p.huang

CC:
shawn.p.huang_gmail.com, fujiwara

Base URL:
git://github.com/ibus/ibus.git@master

Visibility:
Public.

More Reviews

Description

Remove transfer container in ibus_engine_simple_add_table.

Patch Set 2 : Updated with message #2. #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -5 lines)			Patch
M	engine/main.vala	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/ibusenginesimple.h	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
M	src/ibusenginesimple.c	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Peng

lgtm with comments https://codereview.appspot.com/6909049/diff/1/src/ibusenginesimple.h File src/ibusenginesimple.h (right): https://codereview.appspot.com/6909049/diff/1/src/ibusenginesimple.h#newcode100 src/ibusenginesimple.h:100: * @data: (element-type guint16) (array): The ...

11 years, 5 months ago (2012-12-07 20:54:27 UTC) #2

fujiwara

11 years, 5 months ago (2012-12-07 21:41:45 UTC) #3

https://codereview.appspot.com/6909049/diff/1/src/ibusenginesimple.h
File src/ibusenginesimple.h (right):

https://codereview.appspot.com/6909049/diff/1/src/ibusenginesimple.h#newcode113
src/ibusenginesimple.h:113: guint16              *data,
On 2012/12/07 20:54:28, Peng wrote:
> I think 'const guint16 *' is better.

Done.

Expand All Messages | Collapse All Messages