Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(282)

Issue 6909049: Remove transfer container in ibus_engine_simple_add_table. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 11 months ago by fujiwara
Modified:
11 years, 11 months ago
Reviewers:
shawn.p.huang
CC:
shawn.p.huang_gmail.com, fujiwara
Base URL:
git://github.com/ibus/ibus.git@master
Visibility:
Public.

Description

Remove transfer container in ibus_engine_simple_add_table.

Patch Set 1 #

Total comments: 3

Patch Set 2 : Updated with message #2. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M engine/main.vala View 1 1 chunk +1 line, -1 line 0 comments Download
M src/ibusenginesimple.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M src/ibusenginesimple.c View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
fujiwara
11 years, 11 months ago (2012-12-07 20:30:49 UTC) #1
Peng
lgtm with comments https://codereview.appspot.com/6909049/diff/1/src/ibusenginesimple.h File src/ibusenginesimple.h (right): https://codereview.appspot.com/6909049/diff/1/src/ibusenginesimple.h#newcode100 src/ibusenginesimple.h:100: * @data: (element-type guint16) (array): The ...
11 years, 11 months ago (2012-12-07 20:54:27 UTC) #2
fujiwara
11 years, 11 months ago (2012-12-07 21:41:45 UTC) #3
https://codereview.appspot.com/6909049/diff/1/src/ibusenginesimple.h
File src/ibusenginesimple.h (right):

https://codereview.appspot.com/6909049/diff/1/src/ibusenginesimple.h#newcode113
src/ibusenginesimple.h:113: guint16              *data,
On 2012/12/07 20:54:28, Peng wrote:
> I think 'const guint16 *' is better.

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b