Issue 6907052: Improve handling of inverse clip paths in GrClipMaskManager.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6907052: Improve handling of inverse clip paths in GrClipMaskManager. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 6 months ago by bsalomon

Modified:
11 years, 6 months ago

Reviewers:
robertphillips

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Improve handling of inverse clip paths in GrClipMaskManager. Will require rebaselining of complexclip_aa and complexclip_aa_layer on GPU. R=robertphillips@google.com Committed: https://code.google.com/p/skia/source/detail?r=6712

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+71 lines, -27 lines)			Patch
M	include/core/SkClipStack.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/core/SkClipStack.cpp	View		1 chunk	+15 lines, -0 lines	0 comments	Download
M	src/core/SkTLList.h	View		1 chunk	+8 lines, -6 lines	0 comments	Download
M	src/gpu/GrClipMaskManager.cpp	View	1	5 chunks	+28 lines, -16 lines	0 comments	Download
M	src/gpu/GrReducedClip.cpp	View	1	2 chunks	+16 lines, -5 lines	1 comment	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

robertphillips

11 years, 6 months ago (2012-12-07 17:48:20 UTC) #2

LGTM + 1 comment nit

https://codereview.appspot.com/6907052/diff/1006/src/gpu/GrReducedClip.cpp
File src/gpu/GrReducedClip.cpp (right):

https://codereview.appspot.com/6907052/diff/1006/src/gpu/GrReducedClip.cpp#ne...
src/gpu/GrReducedClip.cpp:327: // Intersecting an inverse shape is the same as
differencing the non-inverse shape.
_is_ the same

Expand All Messages | Collapse All Messages