Issue 6907049: openstack: revert commit with broken tests

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6907049: openstack: revert commit with broken tests

Can't Edit
Can't Publish+Mail
Start Review

Created:
5 years, 1 month ago by fwereade

Modified:
5 years, 1 month ago

Reviewers:
mp+138758, dimitern

Visibility:
Public.

Description

openstack: revert commit with broken tests https://code.launchpad.net/~fwereade/juju-core/revert-broken-provider/+merge/138758 (do not edit description out of merge proposal)

Patch Set 1 #

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+61 lines, -304 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	environs/openstack/config.go	View	3 chunks	+27 lines, -8 lines	0 comments	Download
M	environs/openstack/config_test.go	View	3 chunks	+6 lines, -10 lines	0 comments	Download
D	environs/openstack/live_test.go	View	1 chunk	+0 lines, -153 lines	0 comments	Download
M	environs/openstack/local_test.go	View	1 chunk	+8 lines, -2 lines	0 comments	Download
M	environs/openstack/provider.go	View	4 chunks	+18 lines, -114 lines	0 comments	Download
D	environs/openstack/provider_test.go	View	1 chunk	+0 lines, -17 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

dimitern

5 years, 1 month ago (2012-12-07 15:48:08 UTC) #2

On 2012/12/07 15:40:33, fwereade wrote:
> Please take a look.

LGTM

We should fix the broken code and reapply the reverted functionality, but for
now this unbreaks trunk.

Expand All Messages | Collapse All Messages