Allow deserialized discovery docs to be passed to build_from_document().

[Ali Afshar, 2012-12-07 23:15:58]

On 2012/12/07 20:45:54, jcgregorio_google wrote:

Consider refactoring so that we have two separate functions, one from a string
and one from a dict?

[jcgregorio_google, 2012-12-10 14:02:14]

On 2012/12/07 23:15:58, Ali Afshar wrote:
> On 2012/12/07 20:45:54, jcgregorio_google wrote:
> 
> Consider refactoring so that we have two separate functions, one from a string
> and one from a dict?

Seems a little heavy handed to have a new function for that as it is still
building from a discovery document, we just accept the serialized and the
deserialized form. A new function would be appropriate if it was building a
service object from something completely different, for example, we may be
adding a build_from_cache() function.

[Ali Afshar, 2012-12-10 14:45:49]

On 2012/12/10 14:02:14, jcgregorio_google wrote:
> On 2012/12/07 23:15:58, Ali Afshar wrote:
> > On 2012/12/07 20:45:54, jcgregorio_google wrote:
> > 
> > Consider refactoring so that we have two separate functions, one from a
string
> > and one from a dict?
> 
> Seems a little heavy handed to have a new function for that as it is still
> building from a discovery document, we just accept the serialized and the
> deserialized form. A new function would be appropriate if it was building a
> service object from something completely different, for example, we may be
> adding a build_from_cache() function.

As you wish. I thought it would be convenient to have a single line function,
while not relying on the type check.

[jcgregorio_google, 2012-12-10 15:25:27]

Committed in
http://code.google.com/p/google-api-python-client/source/detail?r=ed1095576a2...

On 2012/12/10 14:45:49, Ali Afshar wrote:
> On 2012/12/10 14:02:14, jcgregorio_google wrote:
> > On 2012/12/07 23:15:58, Ali Afshar wrote:
> > > On 2012/12/07 20:45:54, jcgregorio_google wrote:
> > > 
> > > Consider refactoring so that we have two separate functions, one from a
> string
> > > and one from a dict?
> > 
> > Seems a little heavy handed to have a new function for that as it is still
> > building from a discovery document, we just accept the serialized and the
> > deserialized form. A new function would be appropriate if it was building a
> > service object from something completely different, for example, we may be
> > adding a build_from_cache() function.
> 
> As you wish. I thought it would be convenient to have a single line function,
> while not relying on the type check.