Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2120)

Issue 6904069: Modifications to GrPatherRenderer(Chain) interfaces to support clip mask manager. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years ago by bsalomon
Modified:
12 years ago
Reviewers:
robertphillips
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Modifications to GrPatherRenderer(Chain) interfaces to support clip mask manager. R=robertphillips@google.com Committed: https://code.google.com/p/skia/source/detail?r=6741

Patch Set 1 #

Patch Set 2 : #

Total comments: 10
Unified diffs Side-by-side diffs Delta from patch set Stats (+303 lines, -249 lines) Patch
M gyp/gpu.gypi View 2 chunks +1 line, -1 line 0 comments Download
M include/core/SkTLazy.h View 1 chunk +10 lines, -0 lines 2 comments Download
M include/gpu/GrContext.h View 1 3 chunks +8 lines, -6 lines 0 comments Download
A + include/gpu/GrPathRendererChain.h View 1 3 chunks +26 lines, -12 lines 2 comments Download
M src/gpu/GrAddPathRenderers_default.cpp View 1 chunk +4 lines, -9 lines 0 comments Download
M src/gpu/GrClipMaskManager.cpp View 1 6 chunks +33 lines, -18 lines 0 comments Download
M src/gpu/GrContext.cpp View 2 chunks +11 lines, -8 lines 0 comments Download
M src/gpu/GrDefaultPathRenderer.h View 1 chunk +25 lines, -27 lines 0 comments Download
M src/gpu/GrDefaultPathRenderer.cpp View 2 chunks +12 lines, -7 lines 0 comments Download
M src/gpu/GrPathRenderer.h View 1 2 chunks +88 lines, -57 lines 6 comments Download
D src/gpu/GrPathRendererChain.h View 1 chunk +0 lines, -69 lines 0 comments Download
M src/gpu/GrPathRendererChain.cpp View 3 chunks +33 lines, -5 lines 0 comments Download
M src/gpu/GrSoftwarePathRenderer.h View 1 1 chunk +10 lines, -6 lines 0 comments Download
M src/gpu/GrSoftwarePathRenderer.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
M src/gpu/GrStencilAndCoverPathRenderer.h View 1 chunk +16 lines, -16 lines 0 comments Download
M src/gpu/GrStencilAndCoverPathRenderer.cpp View 1 chunk +8 lines, -7 lines 0 comments Download
M src/gpu/gl/GrGLProgram.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLProgram.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGpuGL_program.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M tests/GLProgramsTest.cpp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3
bsalomon
This will enable the alpha clip mask generator to find a PR that it can ...
12 years ago (2012-12-10 16:24:52 UTC) #1
robertphillips
LGTM + 1 question & some comment suggestions https://codereview.appspot.com/6904069/diff/2001/include/core/SkTLazy.h File include/core/SkTLazy.h (right): https://codereview.appspot.com/6904069/diff/2001/include/core/SkTLazy.h#newcode132 include/core/SkTLazy.h:132: T* ...
12 years ago (2012-12-10 17:31:33 UTC) #2
bsalomon
12 years ago (2012-12-10 19:10:41 UTC) #3
https://codereview.appspot.com/6904069/diff/2001/include/core/SkTLazy.h
File include/core/SkTLazy.h (right):

https://codereview.appspot.com/6904069/diff/2001/include/core/SkTLazy.h#newco...
include/core/SkTLazy.h:132: T* writable() {
On 2012/12/10 17:31:33, robertphillips wrote:
> Should we have a "&& NULL != fObj" here or maybe an assert?

Done. (assert)

https://codereview.appspot.com/6904069/diff/2001/include/gpu/GrPathRendererCh...
File include/gpu/GrPathRendererChain.h (right):

https://codereview.appspot.com/6904069/diff/2001/include/gpu/GrPathRendererCh...
include/gpu/GrPathRendererChain.h:56: /** Returns a GrPathRenderer compatible
with the request if one is available. If the caller
On 2012/12/10 17:31:33, robertphillips wrote:
> to the path to -> the path to

Done.

https://codereview.appspot.com/6904069/diff/2001/src/gpu/GrPathRenderer.h
File src/gpu/GrPathRenderer.h (right):

https://codereview.appspot.com/6904069/diff/2001/src/gpu/GrPathRenderer.h#new...
src/gpu/GrPathRenderer.h:55: *
On 2012/12/10 17:31:33, robertphillips wrote:
> can supports -> can provide

Done.

https://codereview.appspot.com/6904069/diff/2001/src/gpu/GrPathRenderer.h#new...
src/gpu/GrPathRenderer.h:59: *                    indicates including support
for simultaneous color and stenciling with
On 2012/12/10 17:31:33, robertphillips wrote:
> covered AA -> covered by AA

Done.

https://codereview.appspot.com/6904069/diff/2001/src/gpu/GrPathRenderer.h#new...
src/gpu/GrPathRenderer.h:155: /**
On 2012/12/10 17:31:33, robertphillips wrote:
> drawPath -> onStencilPath

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b