Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(16)

Issue 6892044: fix readytotest selector for IE testing (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 4 months ago by felix8a
Modified:
13 years, 4 months ago
Reviewers:
kpreid2
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

For some reason I don't understand yet, the xpath selector //*[@class='readytotest'] fails to match a <div class="readytotest"> in IE. No match means the browser test driver never thinks the browser is ready, so the tests hang indefinitely. This CL replaces that selenium By.xpath matcher with By.className, which does work on IE. //*[contains(@class,'foo')] does work, so those don't need to be changed.

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tests/com/google/caja/plugin/BrowserTestCase.java View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 3
felix8a
13 years, 4 months ago (2012-12-05 20:28:27 UTC) #1
kpreid2
LGTM https://codereview.appspot.com/6892044/diff/1/tests/com/google/caja/plugin/BrowserTestCase.java File tests/com/google/caja/plugin/BrowserTestCase.java (right): https://codereview.appspot.com/6892044/diff/1/tests/com/google/caja/plugin/BrowserTestCase.java#newcode278 tests/com/google/caja/plugin/BrowserTestCase.java:278: By.className("readytotest")); This is (presumably) more correct anyway, as ...
13 years, 4 months ago (2012-12-05 20:29:52 UTC) #2
felix8a
13 years, 4 months ago (2012-12-05 20:33:52 UTC) #3
@r5177
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b