Issue 6891047: add query to pixelref for its encoded data (if it has any)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6891047: add query to pixelref for its encoded data (if it has any) (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years ago by reed1

Modified:
12 years ago

Reviewers:
Leon, DerekS

CC:
skia-review_googlegroups.com, Alpha, edisonn

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

add query to pixelref for its encoded data (if it has any) Committed: https://code.google.com/p/skia/source/detail?r=6689

Patch Set 2 : #

Created: 12 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -0 lines)			Patch
	M	include/core/SkPixelRef.h	View	1	3 chunks	+16 lines, -0 lines	0 comments	Download
	M	src/core/SkPixelRef.cpp	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 7

Expand All Messages | Collapse All Messages

DerekS

https://codereview.appspot.com/6891047/diff/1/include/core/SkPixelRef.h File include/core/SkPixelRef.h (right): https://codereview.appspot.com/6891047/diff/1/include/core/SkPixelRef.h#newcode119 include/core/SkPixelRef.h:119: kPNG_EncodedFormat = 1 << 0, do we want them ...

12 years ago (2012-12-06 01:24:04 UTC) #2

reed1

yea, I goofed up with the bit field. Alpha suggests that instead of the caller ...

12 years ago (2012-12-06 01:29:58 UTC) #3

reed1

new patch simplifies API for now. No doubt we can tweak this interface as we ...

12 years ago (2012-12-06 05:52:52 UTC) #4

lgtm

Expand All Messages | Collapse All Messages