Issue 6890045: Make the clip reducer operate on int rects. Remove redundant Gr from func

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6890045: Make the clip reducer operate on int rects. Remove redundant Gr from func (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years ago by bsalomon

Modified:
12 years ago

Reviewers:
robertphillips

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Make the clip reducer operate on int rects. Remove redundant Gr from func name. R=robertphillips@google.com Committed: https://code.google.com/p/skia/source/detail?r=6688

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Created: 12 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+115 lines, -21 lines)			Patch
M	src/gpu/GrReducedClip.h	View	1	1 chunk	+13 lines, -6 lines	1 comment	Download
M	src/gpu/GrReducedClip.cpp	View		8 chunks	+90 lines, -14 lines	0 comments	Download
M	tests/ClipStackTest.cpp	View		2 chunks	+12 lines, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

robertphillips

12 years ago (2012-12-06 14:12:41 UTC) #2

LGTM + 1 typo correction

https://codereview.appspot.com/6890045/diff/2001/src/gpu/GrReducedClip.h
File src/gpu/GrReducedClip.h (right):

https://codereview.appspot.com/6890045/diff/2001/src/gpu/GrReducedClip.h#newc...
src/gpu/GrReducedClip.h:27: * If tighterBounds is specified then it is assumed
that the caller will implicitly clip agains it.
agains -> against

Expand All Messages | Collapse All Messages