Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1602)

Issue 6884053: Ensured that the mUsesPointSprites flag is properly preserved when loading shaders from binary cach… (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 5 months ago by Brandon Jones
Modified:
11 years, 5 months ago
Reviewers:
kbr1, dgkoch, John Bauman
CC:
angleproject-review_googlegroups.com
Base URL:
http://angleproject.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Ensured that the mUsesPointSprites flag is properly preserved when loading shaders from binary cache. BUG=https://code.google.com/p/angleproject/issues/detail?id=389 Committed: https://code.google.com/p/angleproject/source/detail?r=1560

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M src/common/version.h View 1 chunk +1 line, -1 line 0 comments Download
M src/libGLESv2/ProgramBinary.cpp View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7
Brandon Jones
11 years, 5 months ago (2012-12-06 17:50:25 UTC) #1
kbr1
Please edit the ChangeList description to point to a bug report which also points to ...
11 years, 5 months ago (2012-12-06 17:57:44 UTC) #2
Brandon Jones
Original patch set didn't move BUILD_REVISION forward enough. Corrected.
11 years, 5 months ago (2012-12-06 17:57:52 UTC) #3
Brandon Jones
This affects Chrome 24+, but not 23. We will want to backport this fix before ...
11 years, 5 months ago (2012-12-06 18:10:14 UTC) #4
dgkoch
LGTM.
11 years, 5 months ago (2012-12-06 18:12:11 UTC) #5
Brandon Jones
I don't believe that I have commit rights for this repository, so someone else may ...
11 years, 5 months ago (2012-12-06 18:13:11 UTC) #6
dgkoch
11 years, 5 months ago (2012-12-06 18:20:25 UTC) #7
On 2012/12/06 18:13:11, Brandon Jones wrote:
> I don't believe that I have commit rights for this repository, so someone else
> may have to commit this CL

I just added you.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b