Issue 6874064: optimize translate and scale

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6874064: optimize translate and scale (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 1 month ago by reed1

Modified:
12 years, 1 month ago

Reviewers:
bsalomon

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

optimize translate and scale add map2() to optimize for mapping an array of 2D points into homogeneous 4-vector Committed: https://code.google.com/p/skia/source/detail?r=6685

Patch Set 3 : #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+399 lines, -43 lines)			Patch
M	include/utils/SkMatrix44.h	View		6 chunks	+16 lines, -5 lines	0 comments	Download
M	src/utils/SkMatrix44.cpp	View	1 2	9 chunks	+274 lines, -38 lines	0 comments	Download
M	tests/Matrix44Test.cpp	View	1 2	2 chunks	+109 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bsalomon

lgtm https://codereview.appspot.com/6874064/diff/2001/include/utils/SkMatrix44.h File include/utils/SkMatrix44.h (right): https://codereview.appspot.com/6874064/diff/2001/include/utils/SkMatrix44.h#newcode40 include/utils/SkMatrix44.h:40: Way to make that housekeeper bot earn its ...

12 years, 1 month ago (2012-12-05 21:56:29 UTC) #2

reed1

12 years, 1 month ago (2012-12-05 22:13:49 UTC) #3

added unittest for map2(), which found a copy/paste bug!

dst4[0] = 
dst4[0] = 
dst4[2] = 
dst4[3] = 

fixed.

Expand All Messages | Collapse All Messages