Fix red colour in rgb value in pango.vala

Fix red colour in rgb value in pango.vala

The red part of the rgb value was always passed as 0
to Pango.attr_foreground_new(r, g, b) and
Pango.attr_background_new(r, g, b).

BUG=

[Peng, 2012-12-03 13:33:56]

lgtm with one comment

https://codereview.appspot.com/6874050/diff/1/ui/gtk3/pango.vala
File ui/gtk3/pango.vala (left):

https://codereview.appspot.com/6874050/diff/1/ui/gtk3/pango.vala#oldcode55
ui/gtk3/pango.vala:55: uint16 b = (uint16)(attr.value & 0x000000ff) << 8;
Could you please fix it as well?

[maiku.fabian, 2012-12-03 13:41:08]

On 2012/12/03 13:33:56, Peng wrote:
> lgtm with one comment
> 
> https://codereview.appspot.com/6874050/diff/1/ui/gtk3/pango.vala
> File ui/gtk3/pango.vala (left):
> 
> https://codereview.appspot.com/6874050/diff/1/ui/gtk3/pango.vala#oldcode55
> ui/gtk3/pango.vala:55: uint16 b = (uint16)(attr.value & 0x000000ff) << 8;
> Could you please fix it as well?

That line works already as it is.

[Peng, 2012-12-03 15:21:56]

On 2012/12/03 13:41:08, maiku.fabian wrote:
> On 2012/12/03 13:33:56, Peng wrote:
> > lgtm with one comment
> > 
> > https://codereview.appspot.com/6874050/diff/1/ui/gtk3/pango.vala
> > File ui/gtk3/pango.vala (left):
> > 
> > https://codereview.appspot.com/6874050/diff/1/ui/gtk3/pango.vala#oldcode55
> > ui/gtk3/pango.vala:55: uint16 b = (uint16)(attr.value & 0x000000ff) << 8;
> > Could you please fix it as well?
> 
> That line works already as it is.

Yes, I know. Because blue only uses low 16bits. But for those expressions, I
thought vala will do bit shift first, and then the type cast. But seems I was
wrong. So I would like add brackets for blue as well. To make it more readable.

[maiku.fabian, 2012-12-03 15:23:00]

On 2012/12/03 15:21:56, Peng wrote:
> On 2012/12/03 13:41:08, maiku.fabian wrote:
> > On 2012/12/03 13:33:56, Peng wrote:
> > > lgtm with one comment
> > > 
> > > https://codereview.appspot.com/6874050/diff/1/ui/gtk3/pango.vala
> > > File ui/gtk3/pango.vala (left):
> > > 
> > > https://codereview.appspot.com/6874050/diff/1/ui/gtk3/pango.vala#oldcode55
> > > ui/gtk3/pango.vala:55: uint16 b = (uint16)(attr.value & 0x000000ff) << 8;
> > > Could you please fix it as well?
> > 
> > That line works already as it is.
> 
> Yes, I know. Because blue only uses low 16bits. But for those expressions, I
> thought vala will do bit shift first, and then the type cast. But seems I was
> wrong. So I would like add brackets for blue as well. To make it more
readable.

OK, doing this ...

[Peng, 2012-12-04 15:51:30]

I just landed this CL. Please close it. Thanks.
On 2012/12/03 15:23:00, maiku.fabian wrote:
> On 2012/12/03 15:21:56, Peng wrote:
> > On 2012/12/03 13:41:08, maiku.fabian wrote:
> > > On 2012/12/03 13:33:56, Peng wrote:
> > > > lgtm with one comment
> > > > 
> > > > https://codereview.appspot.com/6874050/diff/1/ui/gtk3/pango.vala
> > > > File ui/gtk3/pango.vala (left):
> > > > 
> > > >
https://codereview.appspot.com/6874050/diff/1/ui/gtk3/pango.vala#oldcode55
> > > > ui/gtk3/pango.vala:55: uint16 b = (uint16)(attr.value & 0x000000ff) <<
8;
> > > > Could you please fix it as well?
> > > 
> > > That line works already as it is.
> > 
> > Yes, I know. Because blue only uses low 16bits. But for those expressions, I
> > thought vala will do bit shift first, and then the type cast. But seems I
was
> > wrong. So I would like add brackets for blue as well. To make it more
> readable.
> 
> OK, doing this ...