Issue 6873073: Add bench_pictures config

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6873073: Add bench_pictures config (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 1 month ago by EricB

Modified:
12 years, 1 month ago

Reviewers:
DerekS, epoger, rmistry

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Add bench_pictures config Committed: https://code.google.com/p/skia/source/detail?r=6768

Patch Set 2 : #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+130 lines, --1 lines)			Patch
A	tools/__init__.py	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A	tools/bench_pictures.cfg	View	1	1 chunk	+85 lines, -0 lines	0 comments	Download
A	tools/bench_pictures_cfg_helper.py	View		1 chunk	+46 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

EricB

This comes directly from https://codereview.appspot.com/6927050/

12 years, 1 month ago (2012-12-12 19:41:50 UTC) #1

epoger

LGTM https://codereview.appspot.com/6873073/diff/1/tools/bench_pictures.cfg File tools/bench_pictures.cfg (right): https://codereview.appspot.com/6873073/diff/1/tools/bench_pictures.cfg#newcode9 tools/bench_pictures.cfg:9: bench_pictures_cfg dictionary. Everything else in this file is ...

12 years, 1 month ago (2012-12-12 19:47:33 UTC) #2

EricB

12 years, 1 month ago (2012-12-12 20:13:42 UTC) #4

Message was sent while issue was closed.

Committed as r6768.

https://codereview.appspot.com/6873073/diff/1/tools/bench_pictures.cfg
File tools/bench_pictures.cfg (right):

https://codereview.appspot.com/6873073/diff/1/tools/bench_pictures.cfg#newcode9
tools/bench_pictures.cfg:9: bench_pictures_cfg dictionary. Everything else in
this file is for convenience.
On 2012/12/12 19:47:34, epoger wrote:
> suggest "for convenience" -> "to construct that dictionary"

Done.

Expand All Messages | Collapse All Messages