Issue 6873059: Fix embed and gadget page also.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6873059: Fix embed and gadget page also. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 7 months ago by jcgregorio_google

Modified:
12 years, 7 months ago

Reviewers:
Ali Afshar

CC:
google-api-python-client_googlegroups.com

Visibility:
Public.

Description

Embed and Gadget pages should also point to the new location for docs.

Patch Set 1 #

Total comments: 2

Created: 12 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -4 lines)			Patch
M	samples/api-python-client-doc/embed.html	View	1 chunk	+1 line, -1 line	2 comments	Download
M	samples/api-python-client-doc/gadget.html	View	1 chunk	+1 line, -1 line	0 comments	Download
M	samples/api-python-client-doc/main.py	View	1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Ali Afshar

LGTM https://codereview.appspot.com/6873059/diff/1/samples/api-python-client-doc/embed.html File samples/api-python-client-doc/embed.html (right): https://codereview.appspot.com/6873059/diff/1/samples/api-python-client-doc/embed.html#newcode71 samples/api-python-client-doc/embed.html:71: <td><a target=_top href="https://google-api-client-libraries.appspot.com/documentation/{{ item.name }}/{{ item.version }}/python/latest/">PyDoc</a></td> Should ...

12 years, 7 months ago (2012-12-11 23:18:19 UTC) #2

jcgregorio_google

https://codereview.appspot.com/6873059/diff/1/samples/api-python-client-doc/embed.html File samples/api-python-client-doc/embed.html (right): https://codereview.appspot.com/6873059/diff/1/samples/api-python-client-doc/embed.html#newcode71 samples/api-python-client-doc/embed.html:71: <td><a target=_top href="https://google-api-client-libraries.appspot.com/documentation/{{ item.name }}/{{ item.version }}/python/latest/">PyDoc</a></td> safe_version was ...

12 years, 7 months ago (2012-12-12 15:17:55 UTC) #3

jcgregorio_google

12 years, 7 months ago (2012-12-12 15:21:20 UTC) #4

Committed in
http://code.google.com/p/google-api-python-client/source/detail?r=93573c67e2b...

On 2012/12/12 15:17:55, jcgregorio_google wrote:
>
https://codereview.appspot.com/6873059/diff/1/samples/api-python-client-doc/e...
> File samples/api-python-client-doc/embed.html (right):
> 
>
https://codereview.appspot.com/6873059/diff/1/samples/api-python-client-doc/e...
> samples/api-python-client-doc/embed.html:71: <td><a target=_top
> href="https://google-api-client-libraries.appspot.com/documentation/{{
item.name
> }}/{{ item.version }}/python/latest/">PyDoc</a></td>
> safe_version was just the version with any underscores replaced with periods,
> which isn't right for google-api-client-libraries.
> 
> On 2012/12/11 23:18:19, Ali Afshar wrote:
> > Should this be item.safe_version? Is there an equivalent item.safe_name?

Expand All Messages | Collapse All Messages